Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#212] Refactor: msw 관련 코드 제거 #213

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ienrum
Copy link
Collaborator

@ienrum ienrum commented Jul 23, 2024

💬 Issue Number

closes #212

🤷‍♂️ Description

작업 내용에 대한 설명

msw 관련 코드를 제거하였습니다.
AuthenticatedRoutes 도 렌더링에 부하를 줄것같아 제거하였습니다.

📷 Screenshots

작업 결과물

👻 Good Function

팀원에게 공유하고 싶은 함수나 코드 일부

📋 Check List

PR 전 체크해주세요.

  • Merge 하는 브랜치가 올바른가?
  • 코딩컨벤션을 준수하는가?
  • PR과 관련없는 변경사항이 없는가?

📒 Remarks

팀원이 코드리뷰 시 주의할 점 또는 말하고 싶은 점 특이사항

@ienrum ienrum added the 🔨 Refactor 코드 리팩토링 label Jul 23, 2024
@ienrum ienrum self-assigned this Jul 23, 2024
Copy link

🚀 Storybook is deployed! View it here: https://6621243cb767d61b79ad0f3c-zurzvkbtfm.chromatic.com/

Copy link
Contributor

@HoberMin HoberMin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

감사합니다 ! 빌드에러만 잡아주십셔 :)

Copy link

🚀 Storybook is deployed! View it here: https://6621243cb767d61b79ad0f3c-votllwesox.chromatic.com/

@ienrum ienrum force-pushed the #212/refactor/remove-msw/chae branch from e0fbe81 to 72e0a95 Compare July 23, 2024 02:20
Copy link

🚀 Storybook is deployed! View it here: https://6621243cb767d61b79ad0f3c-whggwstwqa.chromatic.com/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔨 Refactor 코드 리팩토링
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Refactor] msw 제거 작업
2 participants