Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#172] Style: 전반적인 UI수정 #180

Merged
merged 8 commits into from
Jul 16, 2024
Merged

[#172] Style: 전반적인 UI수정 #180

merged 8 commits into from
Jul 16, 2024

Conversation

HoberMin
Copy link
Contributor

💬 Issue Number

closes #172

🤷‍♂️ Description

작업 내용에 대한 설명

  • UI 변경에 따른 전체적인 UI를 수정했습니다.
  • 비로그인 사용자에 대한 접근 권한을 수정했습니다.

📋 Check List

PR 전 체크해주세요.

  • Merge 하는 브랜치가 올바른가?
  • 코딩컨벤션을 준수하는가?
  • PR과 관련없는 변경사항이 없는가?

📒 Remarks

팀원이 코드리뷰 시 주의할 점 또는 말하고 싶은 점 특이사항

  • 수혁님 : 수혁님 다른 코드들은 같은 로직으로 작성했을 때 비로그인인 경우 페이지 라우팅이 발생합니다. 하지만, 댓글 작성페이지의 경우 라우팅이 되지 않아요. 해당 부분 확인해주시면 감사하겠습니다. useCreateComment훅 입니다. 라우팅이 되지 않는 이유 찾아주시면 감사하겠습니다.
  • 현진님 토스트창 두번씩 뜨고, 뜨고나서 지워지지 않는 문제가 있습니다. 해당 부분 확인해봐주시면 감사하겠습니다.

@HoberMin HoberMin self-assigned this Jul 14, 2024
@github-actions GitHub Actions
Copy link

🚀 Storybook is deployed! View it here: https://6621243cb767d61b79ad0f3c-bhmdzkirkv.chromatic.com/

hyeonjinan096
hyeonjinan096 approved these changes Jul 15, 2024
View reviewed changes
Copy link
Collaborator

@hyeonjinan096 hyeonjinan096 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

호민님 수고하셨습니다:)

src/app/(auth)/signin/page.tsx Outdated Show resolved Hide resolved
src/app/(post)/createPost/page.tsx Show resolved Hide resolved
src/app/(post)/result/[postId]/hooks/usePostingLike.ts Outdated Show resolved Hide resolved
src/app/users/profile/page.tsx Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

🚀 Storybook is deployed! View it here: https://6621243cb767d61b79ad0f3c-viwaghwuji.chromatic.com/

@hyeonjinan096 hyeonjinan096 merged commit 069f628 into main Jul 16, 2024
3 checks passed
@HoberMin HoberMin deleted the #172/stlye/SON branch July 20, 2024 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hyeonjinan096 hyeonjinan096 hyeonjinan096 approved these changes

Assignees

@HoberMin HoberMin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Style] 각 화면별 스타일링 수정 요구사항을 반영합니다.
2 participants
@HoberMin @hyeonjinan096