Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#158] Feat: Spinner기반의 로딩처리 #159

Merged
merged 4 commits into from
Jul 9, 2024

Conversation

HoberMin
Copy link
Contributor

@HoberMin HoberMin commented Jul 9, 2024

💬 Issue Number

closes #158

🤷‍♂️ Description

작업 내용에 대한 설명

  • Spinner를 구현했습니다 - react-spinners 라이브러리 사용
  • Suspense를 기반으로 로딩화면이 나오도록 구현했습니다
    • 프로필 페이지
    • 유저페이지
    • 게시글 상세페이지
    • 프로필 - 게시글 목록 (좋아요, 댓글, 작성 한 페이지들)
  • 메인페이지는 무한스크롤이 적용되면 로딩처리 되어야 할 것 같아 현재 씌워놓지 않았습니다.

📷 Screenshots

작업 결과물
image

👻 Good Function

팀원에게 공유하고 싶은 함수나 코드 일부

📋 Check List

PR 전 체크해주세요.

  • Merge 하는 브랜치가 올바른가?
  • 코딩컨벤션을 준수하는가?
  • PR과 관련없는 변경사항이 없는가?

📒 Remarks

팀원이 코드리뷰 시 주의할 점 또는 말하고 싶은 점 특이사항

@HoberMin HoberMin self-assigned this Jul 9, 2024
Copy link

github-actions bot commented Jul 9, 2024

🚀 Storybook is deployed! View it here: https://6621243cb767d61b79ad0f3c-wkpeuswphu.chromatic.com/

Copy link

github-actions bot commented Jul 9, 2024

🚀 Storybook is deployed! View it here: https://6621243cb767d61b79ad0f3c-qepqvfxkld.chromatic.com/

Copy link
Collaborator

@hyeonjinan096 hyeonjinan096 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다:)

@HoberMin HoberMin merged commit cf9ce56 into main Jul 9, 2024
3 checks passed
@HoberMin HoberMin deleted the #158/feat/loading-suspense/SON branch July 20, 2024 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feat] 로딩 스피너 구현 및 Suspense 씌우기
2 participants