Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#153] Feat: 팔로우 리스트 페이지 #156

Merged
merged 26 commits into from
Jul 14, 2024

Conversation

ienrum
Copy link
Collaborator

@ienrum ienrum commented Jul 6, 2024

💬 Issue Number

closes #153

🤷‍♂️ Description

작업 내용에 대한 설명

  • getFollowers getFollowees api 구현
  • social 페이지 구현 (followers, followees)

📷 Screenshots

작업 결과물

image

mock 데이터 추가

image

👻 Good Function

팀원에게 공유하고 싶은 함수나 코드 일부

NullableToString (src/apis/follow.ts)

usePostFollowAPI의 제너릭으로 TUserId를 받아서 initialUserId를 받아올 수 있게 했습니다.
그리고 postFollow 함수에 initialUserId를 넣어주도록 했습니다.

만약 initialUserId를 받아오지 않는다면, userId를 넣어주도록 했습니다. (타입 추론을 위해 NullableToString로 타입을 지정해줬습니다.)

📋 Check List

PR 전 체크해주세요.

  • Merge 하는 브랜치가 올바른가?
  • 코딩컨벤션을 준수하는가?
  • PR과 관련없는 변경사항이 없는가?

📒 Remarks

팀원이 코드리뷰 시 주의할 점 또는 말하고 싶은 점 특이사항

@ienrum ienrum added the ✨Feature 새로운 기능 추가 label Jul 6, 2024
@ienrum ienrum self-assigned this Jul 6, 2024
@ienrum ienrum changed the title #153/feat/follow list page/chae [#153] Feat: 팔로우 리스트 페이지 Jul 6, 2024
Copy link

github-actions bot commented Jul 6, 2024

🚀 Storybook is deployed! View it here: https://6621243cb767d61b79ad0f3c-kttphvyhkj.chromatic.com/

Copy link
Contributor

@HoberMin HoberMin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다 !!
깔끔하게 잘 나온 것 같아요 UI테스트는 나중에 해볼게요

src/apis/follow.ts Outdated Show resolved Hide resolved
src/apis/follow.ts Outdated Show resolved Hide resolved
src/apis/follow.ts Outdated Show resolved Hide resolved
src/app/social/_components/FollowList.tsx Show resolved Hide resolved
src/app/social/_components/FollowList.tsx Outdated Show resolved Hide resolved
Copy link

🚀 Storybook is deployed! View it here: https://6621243cb767d61b79ad0f3c-dcrfkzompz.chromatic.com/

Copy link

🚀 Storybook is deployed! View it here: https://6621243cb767d61b79ad0f3c-mgqytgtzvm.chromatic.com/

Copy link

🚀 Storybook is deployed! View it here: https://6621243cb767d61b79ad0f3c-lwswegdeft.chromatic.com/

Copy link
Collaborator

@hyeonjinan096 hyeonjinan096 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수혁님 수고하셨습니다!
follow관련 페이지를 social/followees, social/[userId]/follwees
이렇게 자신이랑 타 이용자 기준으로 페이지를 나누신 거 같은데
동일한 ui구조여서 나눌 필요가 있나하는 생각이 드는 거 같습니다.
자신의 follow기록 볼 때도
social/[myId]/follwees로 넘어가는 건 어떨까요?

src/app/social/_components/FollowButtons/FollowButton.tsx Outdated Show resolved Hide resolved
Copy link

🚀 Storybook is deployed! View it here: https://6621243cb767d61b79ad0f3c-zvkylfdaqd.chromatic.com/

Copy link

🚀 Storybook is deployed! View it here: https://6621243cb767d61b79ad0f3c-gtfjihbllz.chromatic.com/

@HoberMin HoberMin merged commit 6cd1432 into main Jul 14, 2024
3 checks passed
@HoberMin HoberMin deleted the #153/feat/follow-list-page/chae branch July 14, 2024 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨Feature 새로운 기능 추가
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feat] 팔로우/팔로이 목록 페이지 구현
3 participants