-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#153] Feat: 팔로우 리스트 페이지 #156
Conversation
🚀 Storybook is deployed! View it here: https://6621243cb767d61b79ad0f3c-kttphvyhkj.chromatic.com/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
고생하셨습니다 !!
깔끔하게 잘 나온 것 같아요 UI테스트는 나중에 해볼게요
🚀 Storybook is deployed! View it here: https://6621243cb767d61b79ad0f3c-dcrfkzompz.chromatic.com/ |
🚀 Storybook is deployed! View it here: https://6621243cb767d61b79ad0f3c-mgqytgtzvm.chromatic.com/ |
🚀 Storybook is deployed! View it here: https://6621243cb767d61b79ad0f3c-lwswegdeft.chromatic.com/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
수혁님 수고하셨습니다!
follow관련 페이지를 social/followees, social/[userId]/follwees
이렇게 자신이랑 타 이용자 기준으로 페이지를 나누신 거 같은데
동일한 ui구조여서 나눌 필요가 있나하는 생각이 드는 거 같습니다.
자신의 follow기록 볼 때도
social/[myId]/follwees로 넘어가는 건 어떨까요?
🚀 Storybook is deployed! View it here: https://6621243cb767d61b79ad0f3c-zvkylfdaqd.chromatic.com/ |
🚀 Storybook is deployed! View it here: https://6621243cb767d61b79ad0f3c-gtfjihbllz.chromatic.com/ |
💬 Issue Number
🤷♂️ Description
📷 Screenshots
mock 데이터 추가
👻 Good Function
NullableToString (src/apis/follow.ts)
usePostFollowAPI의 제너릭으로 TUserId를 받아서 initialUserId를 받아올 수 있게 했습니다.
그리고 postFollow 함수에 initialUserId를 넣어주도록 했습니다.
만약 initialUserId를 받아오지 않는다면, userId를 넣어주도록 했습니다. (타입 추론을 위해 NullableToString로 타입을 지정해줬습니다.)
📋 Check List
📒 Remarks