Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix line numbers in errors #22

Closed

Conversation

samuelcolvin
Copy link
Contributor

Just integrating #21, and "snap", this happened. 😞

Previously the line number in errors continued to increment for repeated calls to chevron.render.

@coveralls
Copy link

coveralls commented Jul 3, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling 9351d29 on samuelcolvin:fix-line-number into 4ab120b on noahmorrison:master.

@samuelcolvin
Copy link
Contributor Author

samuelcolvin commented Jul 3, 2017

Can we drop 2.6 support?

It's thoroughly obsolete, even 2.7 is ancient history.

Attempting to guess what a language I've never written and don't have an interpretter for can do is no fun.

@samuelcolvin
Copy link
Contributor Author

Also, global variables like this are pretty frowned upon.

Would you consider a class implementation of tokenize?

@noahmorrison
Copy link
Owner

Unfortunately, I do not want to drop support for 2.6. The whole reason I made this instead of using pystache is that pystache does not seem to care about supporting old versions of python nicely (pystache issue 169). Chevron is just import and it "just works". You don't have to worry if you're on an old legacy piece of hardware running a version of python found in a dumpster (basically the situation my brother was in). I have python2.6 installed using the deadsnakes repo ppa:fkrull/deadsnakes inside of WSL.

I agree with axing the globals. I remember cringing while putting those in, but I just wanted to get that feature in :P I'd like to make sure it doesn't introduce much overhead, (I can't imagine it would unless python is doing something horribly wrong). I like chevrons speed more than two ugly variables. Chevron needs a better speed test then what it has now to make sure the speed doesn't regress.

@coveralls
Copy link

coveralls commented Jul 3, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling f046266 on samuelcolvin:fix-line-number into 4ab120b on noahmorrison:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling f046266 on samuelcolvin:fix-line-number into 4ab120b on noahmorrison:master.

@noahmorrison
Copy link
Owner

I fixed the unittest and merged it. I don't know why github didn't auto detect the merge, but merged with d62f57.

@samuelcolvin
Copy link
Contributor Author

Great, thanks.

@samuelcolvin samuelcolvin deleted the fix-line-number branch July 3, 2017 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants