-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix line numbers in errors #22
Conversation
Can we drop 2.6 support? It's thoroughly obsolete, even 2.7 is ancient history. Attempting to guess what a language I've never written and don't have an interpretter for can do is no fun. |
Also, global variables like this are pretty frowned upon. Would you consider a class implementation of |
Unfortunately, I do not want to drop support for 2.6. The whole reason I made this instead of using pystache is that pystache does not seem to care about supporting old versions of python nicely (pystache issue 169). Chevron is just import and it "just works". You don't have to worry if you're on an old legacy piece of hardware running a version of python found in a dumpster (basically the situation my brother was in). I have python2.6 installed using the deadsnakes repo ppa:fkrull/deadsnakes inside of WSL. I agree with axing the globals. I remember cringing while putting those in, but I just wanted to get that feature in :P I'd like to make sure it doesn't introduce much overhead, (I can't imagine it would unless python is doing something horribly wrong). I like chevrons speed more than two ugly variables. Chevron needs a better speed test then what it has now to make sure the speed doesn't regress. |
1 similar comment
f046266
to
1193cd6
Compare
I fixed the unittest and merged it. I don't know why github didn't auto detect the merge, but merged with d62f57. |
Great, thanks. |
Just integrating #21, and "snap", this happened. 😞
Previously the line number in errors continued to increment for repeated calls to
chevron.render
.