-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade runtime #227
Upgrade runtime #227
Conversation
@Milena-Czierlinski & @britsta could you please check if everything is covered? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Questions for understanding:
- A route for changing the default RepositoryAttribute in the Connector should not be exposed, because it is a feature related to the App? So the
isDefault
property is set totrue
for the firstly created RepositoryAttribute of a given IdentityAttribute value type, but it should not be possible to change the default RepositoryAttribute for the time being with a Connector? @Milena-Czierlinski - Also, setting the communication language seems to be a feature more strongly related to the App, which is why there is no Connector route added for it, right? @Magnus-Kuhn
Yes, this is how it is currently planned. |
Your expectation is correct. In the runtime it is implemented the other way around. |
Exactly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. But wait for other reviews.
Readiness checklist