Remove deprecated elements (#174)

* chore: remove deprecated modules

* chore: remove backwards compatibility for creating attributes

* chore: remove ACCOUNT env key mapping

* chore: remove config rewrite from webhooksV2 to webhooks

config/default.json

@@ -103,19 +103,6 @@
             "targets": {},
             "webhooks": []
         },
-        "amqpPublisher": {
-            "enabled": false,
-            "displayName": "AMQP Publisher",
-            "location": "amqpPublisher/AMQPPublisherModule"
-        },
-        "PubSubPublisher": {
-            "enabled": false,
-            "displayName": "PubSub Publisher",
-            "location": "pubSubPublisher/PubSubPublisherModule",
-            "projectId": "",
-            "topic": "",
-            "keyFile": ""
-        },
         "messageBrokerPublisher": {
             "enabled": false,
             "displayName": "Message Broker Publisher",

src/index.ts

@@ -1,5 +1,4 @@
 import { RuntimeConfig } from "@nmshd/runtime";
-import _ from "lodash";
 import nconf from "nconf";
 import { ConnectorRuntime } from "./ConnectorRuntime";
 import { ConnectorRuntimeConfig } from "./ConnectorRuntimeConfig";
@@ -30,21 +29,10 @@ export function createConnectorConfig(overrides?: RuntimeConfig): ConnectorRunti
 
     const connectorConfig = nconf.get();
 
-    if (typeof connectorConfig.modules.webhooksV2 !== "undefined") {
-        // eslint-disable-next-line no-console
-        console.warn("The 'webhooksV2' configuration is deprecated. Please use 'webhooks' instead.");
-
-        connectorConfig.modules.webhooks = _.defaultsDeep(connectorConfig.modules.webhooksV2, connectorConfig.modules.webhooks);
-        delete connectorConfig.modules.webhooksV2;
-    }
-
     return connectorConfig;
 }
 
 const envKeyMapping: Record<string, string> = {
-    // The DATABASE__DB_NAME env variable was called ACCOUNT in the past - we need to keep an alias for backwards compatibility.
-    ACCOUNT: "database:dbName", // eslint-disable-line @typescript-eslint/naming-convention
-
     DATABASE_NAME: "database:dbName", // eslint-disable-line @typescript-eslint/naming-convention
     API_KEY: "infrastructure:httpServer:apiKey", // eslint-disable-line @typescript-eslint/naming-convention
     DATABASE_CONNECTION_STRING: "database:connectionString", // eslint-disable-line @typescript-eslint/naming-convention

src/modules/coreHttpApi/controllers/AttributesController.ts

@@ -1,4 +1,3 @@
-import { ApplicationError } from "@js-soft/ts-utils";
 import { ConsumptionServices, RuntimeErrors, TransportServices } from "@nmshd/runtime";
 import { Inject } from "typescript-ioc";
 import { Accept, Context, DELETE, GET, POST, Path, PathParam, QueryParam, Return, ServiceContext } from "typescript-rest";
@@ -17,19 +16,6 @@ export class AttributesController extends BaseController {
     @POST
     @Accept("application/json")
     public async createRepositoryAttribute(request: any): Promise<Return.NewResource<Envelope>> {
-        const selfAddress = (await this.transportServices.account.getIdentityInfo()).value.address;
-        if (request?.content?.owner && request?.content?.owner !== selfAddress) {
-            throw new ApplicationError(
-                "error.connector.attributes.cannotCreateNotSelfOwnedRepositoryAttribute",
-                "You are not allowed to create an attribute that is not owned by yourself"
-            );
-        }
-        /* We left 'owner' and '@type' optional in the openapi spec for
-         * backwards compatibility. If set, they have to be removed here or the runtime
-         * use case will throw an error. */
-        if (typeof request?.content?.owner !== "undefined") delete request.content.owner;
-        if (request?.content?.["@type"] === "IdentityAttribute") delete request.content["@type"];
-
         const result = await this.consumptionServices.attributes.createRepositoryAttribute(request);
         return this.created(result);
     }