Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Search enhancements: recursive search; search on event attributes #1208

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Search enhancements: recursive search; search on event attributes #1208

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
8e63149
Added UI for searching event attrs
duncanka Dec 11, 2016
ebeaffd
Implemented actual attr search functionality
duncanka Dec 11, 2016
5c9914e
Searching on attrs now works for hierarchy-only categories
duncanka Dec 12, 2016
79ffd97
Searching for unspecified event type allows any attribute/role
duncanka Dec 12, 2016
9cbc2e7
Fixed layout bug in search dialog
duncanka Dec 12, 2016
80883c1
Enabled recursive collection search
duncanka Dec 12, 2016
ca5eafd
Bugfix: switching collections would add attr search widgets
duncanka Dec 12, 2016
e1d5d9e
Fixed default attributes list for event in search
duncanka Dec 12, 2016
4c2258f
Fixed navigation within recursive search results
duncanka Feb 22, 2017
2974c57
Made search scroll to matches, particularly on navigation
duncanka Feb 22, 2017
8ee8593
Fixed scroll-to-match for text searches
duncanka Feb 22, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions client/src/visualizer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2778,7 +2778,7 @@ Util.profileStart('rows');
var text;
if (rtlmode) {
text = svg.text(sentNumGroup, canvasWidth - sentNumMargin + Configuration.visual.margin.x, y - rowPadding,
'' + row.sentence, { 'data-sent': row.sentence });
'' + row.sentence, { 'data-sent': row.sentence });
} else {
text = svg.text(sentNumGroup, sentNumMargin - Configuration.visual.margin.x, y - rowPadding,
'' + row.sentence, { 'data-sent': row.sentence });
Expand Down Expand Up @@ -2835,8 +2835,8 @@ Util.profileStart('chunkFinish');
var nextChunk = data.chunks[chunkNo + 1];
var nextSpace = nextChunk ? nextChunk.space : '';
if (rtlmode) {
// Render every text chunk as a SVG text so we maintain control over the layout. When
// rendering as a SVG span (as brat does), then the browser changes the layout on the
// Render every text chunk as a SVG text so we maintain control over the layout. When
// rendering as a SVG span (as brat does), then the browser changes the layout on the
// X-axis as it likes in RTL mode.
svg.text(textGroup, chunk.textX, chunk.row.textY, chunk.text + nextSpace, {
'data-chunk-id': chunk.index
Expand Down
Loading