gpg-agent: fix compatibility with sh when enableSshSupport #6287
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When
services.gpg-agent.enableSshSupport
is set, the module adds script tohome.sessionVariablesExtra
with non-portable double bracket[[
syntax.The script is written to
hm-session-vars.sh
, which will be referenced by~/.profile
(if managed by home-manager) and sourced bysh
which doesn't support this syntax. (e.g. when logging in graphical session with uwsm, it usessh
to source~/.profile
to get environment variables)The portable single bracket
[
syntax also supports the-z
operator, so we can just use it instead.Checklist
Change is backwards compatible.
Code formatted with
./format
.Code tested through
nix-shell --pure tests -A run.all
ornix develop --ignore-environment .#all
using Flakes.Test cases updated/added. See example.
Commit messages are formatted like
See CONTRIBUTING for more information and recent commit messages for examples.
If this PR adds a new module
Maintainer CC
@rycee