lutris: configuration init #6213
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Steinhagen
force-pushed
the
lutris-options
branch
3 times, most recently
from
0d98f78 to
a5e2f64
Compare
Steinhagen
force-pushed
the
lutris-options
branch
4 times, most recently
from
1613380 to
4a32bfc
Compare
rycee
reviewed
Dec 22, 2024
modules/lib/maintainers.nix
Outdated
Comment on lines
505
to
510
| rapiteanu = { | ||
| name = "Viorel-Cătălin Răpițeanu"; | ||
| email = "[email protected]"; | ||
| github = "Steinhagen"; | ||
| githubId = 4029937; | ||
| }; |
There was a problem hiding this comment.
Since you are already in the Nixpkgs maintainers list you don't need to also add yourself here.
Suggested change
| rapiteanu = { | |
| name = "Viorel-Cătălin Răpițeanu"; | |
| email = "[email protected]"; | |
| github = "Steinhagen"; | |
| githubId = 4029937; | |
| }; |
There was a problem hiding this comment.
I will remove that.
rycee
reviewed
Dec 22, 2024
| cfg = config.programs.lutris; | ||
|
|
||
| cemuConf = '' | ||
| cemu: |
There was a problem hiding this comment.
Doing yaml configurations in this way will prevent users of the module from doing settings that are not provided in the module. Are you sure that it won't be necessary to allow users deeper access?
There was a problem hiding this comment.
There will be a need to allow users deeper access to these. I was thinking of adding an extraConf part for cemu, dolphin, duckstation and ppsspp that is user modfiable. If there is a better method for this, please let me know. Also, any example is greatly appreciated!
Initial work to bring home-manager configuration to Lutris. Due to some limitation on how Lutris rewrites on runtime the .conf file, only the runners and the extra packages will be addressed in this patchset.
Steinhagen
force-pushed
the
lutris-options
branch
from
4a32bfc to
c4a02fe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Initial work to bring home-manager configuration to Lutris.
Due to some limitation on how Lutris rewrites on runtime the .conf file, only the runners and the extra packages will be addressed in this patchset.
With this change, you can automatically configure Lutris to execute a number of runners using nixpkgs instead of relying on the Appimages.
Checklist
Change is backwards compatible.
Code formatted with
./format.Code tested through
nix-shell --pure tests -A run.allornix develop --ignore-environment .#allusing Flakes.Test cases updated/added. See example.
Commit messages are formatted like
See CONTRIBUTING for more information and recent commit messages for examples.
If this PR adds a new module
Maintainer CC