Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib/generators: toSwayConf init #5485

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

sinanmohd
Copy link

@sinanmohd sinanmohd commented Jun 3, 2024

Description

Checklist

  • Change is backwards compatible.

  • Code formatted with ./format.

  • Code tested through nix-shell --pure tests -A run.all or nix develop --ignore-environment .#all using Flakes.

  • Test cases updated/added. See example.

  • Commit messages are formatted like

    {component}: {description}
    
    {long description}
    

    See CONTRIBUTING for more information and recent commit messages for examples.

  • If this PR adds a new module

    • Added myself as module maintainer. See example.

Maintainer CC

@sumnerevans @alexarice @Scrumplex @oxalica

tested in my config
https://github.com/sinanmohd/nixos/blob/master/home/wayland/modules/sway/home.nix

@sinanmohd
Copy link
Author

@sinanmohd sinanmohd force-pushed the sway-generators branch 2 times, most recently from 9321c14 to fd6c12b Compare June 3, 2024 05:20
@sinanmohd sinanmohd force-pushed the sway-generators branch 2 times, most recently from c5e82c3 to fd6c12b Compare July 16, 2024 06:12
@sumnerevans
Copy link
Member

Please squash these into three commits and rebase on latest master.

lib/generators: toSwayConf init
sway: add sinanmohd to maintainers
sway: add settings option

I can't tell if the test failures are due to these changes or not. It doesn't look like it, but the Ubuntu tests must pass.

@sinanmohd
Copy link
Author

sinanmohd commented Sep 5, 2024

all the tests passed on my machine, I can’t reproduce it on my end 🙃
looks like the failed tests are unrelated to the commit

2024-09-04T20:09:06.2598743Z atuin-set-flags: FAILED
2024-09-04T20:09:06.2603177Z bat: FAILED
2024-09-04T20:09:06.2612608Z bat-deprecated-options: FAILED
2024-09-04T20:09:06.2621017Z bemenu-basic-configuration: FAILED
2024-09-04T20:09:06.2627434Z bspwm-configuration: FAILED
2024-09-04T20:09:06.2649918Z cachix: FAILED
2024-09-04T20:09:06.2662217Z cliphist-extra-options: FAILED
2024-09-04T20:09:06.2666919Z emacs-service-27: FAILED
2024-09-04T20:09:06.2679719Z emacs-service-28: FAILED
2024-09-04T20:09:06.2692326Z emacs-service-28-after-graphical-session-target: FAILED
2024-09-04T20:09:06.2708009Z emacs-socket-27: FAILED
2024-09-04T20:09:06.2722281Z emacs-socket-28: FAILED
2024-09-04T20:09:06.2736158Z fnott-systemd-user-service: FAILED
2024-09-04T20:09:06.2746584Z gammastep-basic-configuration: FAILED
2024-09-04T20:09:06.2759241Z gpg-mutable-keyfiles: FAILED
2024-09-04T20:09:06.2762393Z herbstluftwm-simple-config: FAILED
2024-09-04T20:09:06.2784608Z imapnotify: FAILED
2024-09-04T20:09:06.2799528Z mpd-basic-configuration: FAILED
2024-09-04T20:09:06.2816549Z mpd-before-state-version-22_11: FAILED
2024-09-04T20:09:06.2835958Z mpd-mpris-configuration-with-password: FAILED
2024-09-04T20:09:06.2856572Z mpd-start-when-needed: FAILED
2024-09-04T20:09:06.2883958Z mpd-xdg-music-dir: FAILED
2024-09-04T20:09:06.2902934Z mujmap-defaults: FAILED
2024-09-04T20:09:06.2913659Z mujmap-fqdn-and-session-url-specified: FAILED
2024-09-04T20:09:06.2924904Z parcellite: FAILED
2024-09-04T20:09:06.2938011Z pasystray-service: FAILED
2024-09-04T20:09:06.2954087Z pls-bash: FAILED
2024-09-04T20:09:06.2962353Z pls-fish: FAILED
2024-09-04T20:09:06.2977328Z pls-zsh: FAILED
2024-09-04T20:09:06.2992728Z redshift-basic-configuration: FAILED
2024-09-04T20:09:06.3017885Z remmina-basic-config: FAILED
2024-09-04T20:09:06.3024928Z signaturepdf-basic-configuration: FAILED
2024-09-04T20:09:06.3047884Z swayosd: FAILED
2024-09-04T20:09:06.3063669Z syncthing-extra-options: FAILED
2024-09-04T20:09:06.3072998Z systemd-user-config: FAILED
2024-09-04T20:09:06.3092952Z thefuck-integration-enabled: FAILED
2024-09-04T20:09:06.3108991Z thefuck-integration-enabled-instant: FAILED
2024-09-04T20:09:06.3125648Z wlsunset-service: FAILED
2024-09-04T20:09:06.3149559Z xsession-basic: FAILED
2024-09-04T20:09:06.3172139Z zsh-abbr: FAILED
2024-09-04T20:09:06.3179780Z zsh-syntax-highlighting: FAILED

@sinanmohd
Copy link
Author

sinanmohd commented Sep 5, 2024

these tests seems to be failing on github actions for a while now (eg: #5802)
maybe something to do with inconsistencies in github runners ?

there's a one to one match on the failed tests on these prs

This comment was marked as outdated.

@stale stale bot added the status: stale label Dec 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants