Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PrestakingWelcome: implement designer feedback #183

Merged
merged 5 commits into from
Oct 18, 2024

Conversation

mraveux
Copy link
Member

@mraveux mraveux commented Oct 14, 2024

The prestaking welcome page now behave like an “instagram story” or something the like.

@julianbauer
Copy link
Member

Nice! Some minor feedback :)

  • "Let's go button should alread be active. I like that it's not so prominent in the first steps, but can we make it stand out a little more? Let's use the secondary-button colors here: white 10% as background, white 100% for button text
  • The progress bar should always run, unless you're on the last step and finished. Right now, when navigating back it stops sometimes.
  • Mousedown (and similar for touch) should pause the progress bar – mouseup start it again
  • Love the added next/previous hint!

@mraveux
Copy link
Member Author

mraveux commented Oct 14, 2024

The progress bar should always run, unless you're on the last step and finished. Right now, when navigating back it stops sometimes.

About that, it's actually an intended behavior. If you go back it will pause, if you go next it will have a timer. Comes from the idea that if you go back it's to take your time to read, so it would imo be meaningless to have the timer start again. Unless we implement the mousedown/mouseup feature to pause, but...

If I add the Mousedown to pause / Mouseup to continue, then we imo should have something to also hint this behavior, otherwise users may just not know about it and there would be no visible way to pause on a slide, thus lower the user experience.

@julianbauer
Copy link
Member

This is how the instagram behaviour works, and I'd love to mimick this as much as possible, as it's by now not just a pattern used by instagram but by other apps too and lots of people are able to intuitively use it.

That said, I'm okay with not letting the timer run when you go back to a previous step, as long as we introduce the mousedown/mouseup feature. It's a discoverable feature, so no need to hint at it

@mraveux mraveux force-pushed the matheo/wip/instagram-prestake-welcome branch from 557f1a0 to 0d9c8ad Compare October 18, 2024 17:28
@mraveux
Copy link
Member Author

mraveux commented Oct 18, 2024

The "let's go" button disabled style has been updated, and the pause feature implemented while trying to avoid any conflicts with the next/previous arrows as well as the swipe left/right feature on mobile. The branch selector has been updated with the latest state.

@mraveux mraveux force-pushed the matheo/wip/instagram-prestake-welcome branch from 0d9c8ad to a37a31b Compare October 18, 2024 17:39
@mraveux mraveux merged commit 5031148 into master Oct 18, 2024
1 check passed
@mraveux mraveux deleted the matheo/wip/instagram-prestake-welcome branch October 18, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants