Unsubscribe streams #37
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eligioo
force-pushed
the
stefan/unsubscribe-stream
branch
from
1514975 to
52a472e
Compare
Eligioo
force-pushed
the
stefan/unsubscribe-stream
branch
from
52a472e to
f572d6a
Compare
By adding a specialized unsubsribe request handler that lets the server terminates specifc streams
Eligioo
force-pushed
the
stefan/unsubscribe-stream
branch
from
f572d6a to
b592346
Compare
jsdanielh
reviewed
Jan 24, 2025
| if subscription_ids.is_empty() { | ||
| return error_response(request.id, || { | ||
| RpcError::invalid_params(Some( | ||
| "Empty list of subscription ids is provided".to_owned(), |
There was a problem hiding this comment.
Suggested change
| "Empty list of subscription ids is provided".to_owned(), | |
| "Empty list of subscription ids provided".to_owned(), |
Comment on lines
+897
to
+903
| if let Err(e) = forward_notification(notification, &mut tx, &id, &method).await { | ||
| // Break the loop when the channel is closed | ||
| if let Error::Mpsc(_) = e { | ||
| break; | ||
| } | ||
|
|
||
| log::error!("{}", e); |
There was a problem hiding this comment.
Suggested change
| if let Err(e) = forward_notification(notification, &mut tx, &id, &method).await { | |
| // Break the loop when the channel is closed | |
| if let Error::Mpsc(_) = e { | |
| break; | |
| } | |
| log::error!("{}", e); | |
| if let Err(error) = forward_notification(notification, &mut tx, &id, &method).await { | |
| // Break the loop when the channel is closed | |
| if let Error::Mpsc(_) = error { | |
| break; | |
| } | |
| log::error!(error); |
| } | ||
| } | ||
| _ = &mut notify_future => { | ||
| // Break the loop when a unsubscribe notification is received |
There was a problem hiding this comment.
Suggested change
| // Break the loop when a unsubscribe notification is received | |
| // Break the loop when an unsubscribe notification is received |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By adding a specialised unsubscribe request handler that lets the server terminates specific streams.
This PR is build on top of
stefan/axum(#36).Fixes nimiq/core-rs-albatross#3216