-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase validator robustness against mempool errors #2848
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor comments, but it looks good to me.
fn accounts_error( | ||
blockchain: &Blockchain, | ||
error: AccountsError, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fn accounts_error( | |
blockchain: &Blockchain, | |
error: AccountsError, | |
fn from_accounts_error( | |
error: AccountsError, | |
blockchain: &Blockchain, |
I like this better, it is not a deal breaker though.
validator/src/micro.rs
Outdated
|
||
// Add an artificial panic here so that it's easier to catch any remaining | ||
// mempool bugs. | ||
// TODO Remove this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please create an issue for this once this gets merged.
325de1a
to
6c5b66a
Compare
6c5b66a
to
c7977e6
Compare
…on fails This should be removed once #2751 is fixed.
c7977e6
to
ac7aaad
Compare
Allow validators to continue block production, even after failing to construct a block from the current mempool.
Log a detailed error message when block production fails.
fb224ca adds an artificial panic to stop block production to help debug issue #2751. This should be reverted once that issue is fixed.