Increase validator robustness against mempool errors #2848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nibhar
approved these changes
Aug 27, 2024
Comment on lines
+31
to
+33
| fn accounts_error( | ||
| blockchain: &Blockchain, | ||
| error: AccountsError, |
There was a problem hiding this comment.
Suggested change
| fn accounts_error( | |
| blockchain: &Blockchain, | |
| error: AccountsError, | |
| fn from_accounts_error( | |
| error: AccountsError, | |
| blockchain: &Blockchain, |
I like this better, it is not a deal breaker though.
validator/src/micro.rs
Outdated
|
|
||
| // Add an artificial panic here so that it's easier to catch any remaining | ||
| // mempool bugs. | ||
| // TODO Remove this. |
There was a problem hiding this comment.
Please create an issue for this once this gets merged.
Eligioo
approved these changes
Aug 30, 2024
styppo
force-pushed
the
styppo/validator
branch
2 times, most recently
from
325de1a
to
6c5b66a
Compare
jsdanielh
force-pushed
the
styppo/validator
branch
from
6c5b66a
to
c7977e6
Compare
…on fails This should be removed once #2751 is fixed.
jsdanielh
force-pushed
the
styppo/validator
branch
from
c7977e6
to
ac7aaad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow validators to continue block production, even after failing to construct a block from the current mempool.
Log a detailed error message when block production fails.
fb224ca adds an artificial panic to stop block production to help debug issue #2751. This should be reverted once that issue is fixed.