[#104] Add tests for add-ons #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malparty
force-pushed
the
feature/96-add-tailwind-add-on
branch
from
c0801c8
to
ef1912d
Compare
tyrro
force-pushed
the
feature/gh-104-tests-for-addons
branch
2 times, most recently
from
671059a
to
81958bb
Compare
malparty
force-pushed
the
feature/gh-104-tests-for-addons
branch
14 times, most recently
from
3eb3839
to
67bd969
Compare
malparty
requested review from
carryall,
bterone,
hanam1ni,
hoangmirs,
malparty,
rosle and
Nihisil
as code owners
Nihisil
reviewed
Jul 14, 2022
carryall
reviewed
Jul 15, 2022
carryall
approved these changes
Jul 15, 2022
hoangmirs
approved these changes
Jul 18, 2022
.github/workflows/test-cli-tool.yml
Outdated
Comment on lines
31
to
32
| working-directory: ./packages/cli-tool | ||
| run: npm run test |
There was a problem hiding this comment.
As we're using npm workspaces, we can use this command to run tests for cli-tool
Suggested change
| working-directory: ./packages/cli-tool | |
| run: npm run test | |
| run: npm run test --workspace=packages/cli-tool |
There was a problem hiding this comment.
That's a nice one!!! :)
thanks!
20c6bca
malparty
force-pushed
the
feature/gh-104-tests-for-addons
branch
from
0f23510
to
96c1ea8
Compare
malparty
approved these changes
Jul 18, 2022
Nihisil
approved these changes
Jul 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #104
What happened 👀
ScenarioandTestData)Insight 📝
npm ci && lerna bootstrap --cifrom the "root folder", so that it will run the npm ci inside the "packages/cli-tool" folder without NPM error (as there is no package.lock in this sub-folder)references: ["path":".."]./test-appin the .gitignore (just in case of.. sometimes we CTR+C during a test)A
destoptional argument was added so we can specify another "destination" for the template to be generated in.This prevents a conflict between ESlint configurations (as it inherits from parent folders) when the template is generated within the source code folder.
Proof Of Work 📹
Tests are passing
Failing test example
Documentation
Readme.md