-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#255] Generate sample project as a part of test workflow #259
Conversation
ba80854
to
235412d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The rest lgtm
.github/workflows/test.yml
Outdated
with: | ||
token: ${{ secrets.WIKI_ACTION_TOKEN }} | ||
ref: ${{ github.ref }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
with token
is to checkout repo correctly under bot-nimble account to bypass branch protection https://github.com/nimblehq/flutter-templates/pull/211/files#diff-b6be02f3a9d4c7902a0c7ef15e92a821440068867b5fef0a201f8f254f01e94cR16-R17. I don't think we need it for the bot-account to push a commit to a normal PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from @luongvo 's comments, the rest lgtm
@nmint8m Do you have time to resolve reviews on this PR, please? Or I can help you resolve the rest, as this is an important PR for the rest of the contributions 🙏 |
a500935
to
1e8a456
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nmint8m The commit still uses ticket id as 225, not 255 🙏
dbc8f69
to
c8c6983
Compare
What happened 👀
In this PR, I did the following requirements:
generate_mason_bundle
Insight 📝
In the job
generate_sample_project
I addjobs.job_id.needs
togenerate_mason_bundle
to identify that the jobgenerate_mason_bundle
must complete successfully before thisgenerate_sample_project
job will runProof Of Work 📹
Without changes
Skip the job
generate_sample_project
With changes
It's successfully built: https://github.com/nimblehq/flutter-templates/actions/runs/5724239412/job/15510486424
The job
generate_sample_project
passedThere are 2 new commits: