[#17] Refactor

nimblehq · Aug 30, 2023 · 0ae502c · 0ae502c
1 parent 9b5181d
commit 0ae502c
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 16 deletions.
diff --git a/lib/screens/home/home_pages_widget.dart b/lib/screens/home/home_pages_widget.dart
@@ -10,7 +10,6 @@ const _imageOpacity = 0.6;
 class HomePagesWidget extends StatefulWidget {
   final List<SurveyModel> surveys;
   final ValueNotifier<int> currentPage;
-  final PageController _pageController = PageController();
   final VoidCallback onNextButtonPressed;
   final bool isRefreshing;
   final VoidCallback onLoadMore;
@@ -37,13 +36,6 @@ class _HomePagesWidgetState extends State<HomePagesWidget> {
     super.dispose();
   }
 
-  void _handleNextButtonPressed(int index) {
-    if (widget.currentPage.value < widget.surveys.length - 1) {
-      widget.currentPage.value = index + 1;
-      _pageController.jumpToPage(widget.currentPage.value);
-    }
-  }
-
   void _handlePageChanged(int index) {
     widget.currentPage.value = index;
 

diff --git a/lib/screens/home/home_screen.dart b/lib/screens/home/home_screen.dart
@@ -100,8 +100,8 @@ class _HomeScreenState extends ConsumerState<HomeScreen> {
                           extra: survey,
                         );
                       },
-                        onLoadMore: _loadSurveys,
-                        isRefreshing: isRefreshing
+                      onLoadMore: _loadSurveys,
+                      isRefreshing: isRefreshing,
                     ),
                     const HomeHeaderWidget(),
                     Align(

diff --git a/lib/screens/home/home_view_model.dart b/lib/screens/home/home_view_model.dart
@@ -8,7 +8,7 @@ import 'package:survey_flutter/usecases/get_cached_surveys_use_case.dart';
 import 'package:survey_flutter/usecases/get_surveys_use_case.dart';
 
 int _pageNumber = 1;
-const _pageSize = 5;
+const _pageSize = 10;
 List<SurveyModel> _loadedSurveys = [];
 
 final homeViewModelProvider =
@@ -40,14 +40,11 @@ class HomeViewModel extends StateNotifier<HomeState> {
   Stream<String> get error => _error.stream;
 
   void _handleError(Failed result) {
-    var errorMessage = result.getErrorMessage();
-    var isNotFoundError = result.isNotFoundError();
-
-    if (isNotFoundError) {
+    if (result.isNotFoundError()) {
       _surveys.add(_loadedSurveys);
       state = const HomeState.loadSurveysSuccess(false);
     } else {
-      _error.add(errorMessage);
+      _error.add(result.getErrorMessage());
       state = const HomeState.error();
     }
   }