[#491] Enhance CICD workflow for releasing production to Firebase App Distribution #554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n branch on production
thiennguyen0196
requested review from
AVI5HEK,
chornerman,
doannimble,
hoangnguyen92dn,
kaungkhantsoe,
luongvo,
lydiasama,
manh-t,
minhnimble,
ryan-conway,
sleepylee,
toby-thanathip and
Wadeewee
as code owners
thiennguyen0196
had a problem deploying
to
template-compose
GitHub Actions
Error
thiennguyen0196
changed the title
thiennguyen0196
temporarily deployed
to
template-compose
GitHub Actions
Inactive
Kover report for template-compose:🧛 Template - Compose Unit Tests Code Coverage:
|
| File | Coverage |
|---|
Modified Files Not Found In Coverage Report:
deploy_production_to_firebase_app_distribution.yml
deploy_staging_and_production_to_firebase_app_distribution.yml
Codebase cunningly covered by count Shroud 🧛
Generated by 🚫 Danger
luongvo
requested changes
Nov 1, 2023
There was a problem hiding this comment.
@thiennguyen0196 I think we should clone these CD workflows to actual run in the root .github folder to verify & ensure them can work properly 🙏
There was a problem hiding this comment.
Comment on lines
1
to
12
| name: Deploy staging and production to Firebase App Distribution | ||
|
|
||
| on: | ||
| # Trigger the workflow on push action in main branch. | ||
| # So it will trigger when the PR of the feature branch was merged. | ||
| push: | ||
| branches: | ||
| - main | ||
|
|
||
| jobs: | ||
| deploy_staging_and_production_to_firebase_app_distribution: | ||
| name: Deploy staging and production to Firebase App Distribution |
Comment on lines
+22
to
+26
| - name: Set up timezone | ||
| uses: zcong1993/setup-timezone@master | ||
| with: | ||
| timezone: Asia/Bangkok | ||
|
|
There was a problem hiding this comment.
I'm sure deploy workflow does not need to Set up timezone step 🙏 Same for staging workflow
Comment on lines
+41
to
+58
| - name: Run Detekt | ||
| run: ./gradlew detekt | ||
|
|
||
| - name: Archive Detekt reports | ||
| uses: actions/upload-artifact@v3 | ||
| with: | ||
| name: DetektReports | ||
| path: build/reports/detekt/ | ||
|
|
||
| - name: Run unit tests with Kover | ||
| run: ./gradlew koverHtmlReport | ||
|
|
||
| - name: Archive code coverage reports | ||
| uses: actions/upload-artifact@v3 | ||
| with: | ||
| name: CodeCoverageReports | ||
| path: app/build/reports/kover/ | ||
|
|
There was a problem hiding this comment.
IMO, we don't need these code analyzing & testing steps on CD workflows. Let's save our billing resources 🙏 Same for staging workflow
| path: app/build/reports/kover/ | ||
|
|
||
| - name: Build production APK | ||
| run: ./gradlew assembleProductionRelease |
| appId: ${{secrets.FIREBASE_APP_ID_PRODUCTION}} | ||
| serviceCredentialsFileContent: ${{ secrets.FIREBASE_SERVICE_ACCOUNT_CREDENTIAL_FILE_CONTENT }} | ||
| groups: testers | ||
| file: app/build/outputs/apk/production/debug/app-production-release.apk |
There was a problem hiding this comment.
Suggested change
| file: app/build/outputs/apk/production/debug/app-production-release.apk | |
| file: app/build/outputs/apk/production/release/app-production-release.apk |
|
@thiennguyen0196 please provide POW from actual workflows in the root |
thiennguyen0196
temporarily deployed
to
template-compose
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#491
What happened 👀
developbranch onstagingandmainbranch onproductionInsight 📝
N/A
Proof Of Work 📹
Show us the implementation: screenshots, GIFs, etc.