Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance CICD workflow for releasing production to Firebase App Distribution #491

Open
lydiasama opened this issue Jul 18, 2023 · 2 comments
Open

Enhance CICD workflow for releasing production to Firebase App Distribution #491

lydiasama opened this issue Jul 18, 2023 · 2 comments
Assignees
@thiennguyen0196
Labels
priority : normal type : chore

Comments

@lydiasama
Copy link
Contributor

lydiasama commented Jul 18, 2023 •
edited
Loading

Why

Currently, we build ProductionDebug on both Github action and Codemagic workflow (We don't have the step to deploy to Firebase on Bitrise script yet. Besides, we deploy release on the develop branch.

We can enhance the deployment workflow by the following:

  1. Update the CD to deploy from main branch.
  2. Update build script; from ProductionDebug to ProductionRelease, which requires creating the keystore and store on 1P to make the sample scripts more practical.
  3. From this discussion, update the Github action to deploy develop branch on staging, and main branch on production.

Who Benefits?

Android developers
@lydiasama lydiasama added this to the 3.23.0 milestone Jul 18, 2023
@lydiasama lydiasama mentioned this issue Jul 18, 2023
Merged
6 tasks
@luongvo
Copy link
Member

luongvo commented Jul 18, 2023

@lydiasama which requires creating the keystore... 😄

@lydiasama
Copy link
Contributor Author

@luongvo Indeed!. 😵

@ryan-conway ryan-conway self-assigned this Aug 2, 2023
@ryan-conway ryan-conway modified the milestones: 3.23.0, 3.24.0 Aug 30, 2023
@ryan-conway ryan-conway removed their assignment Aug 30, 2023
@ryan-conway ryan-conway modified the milestones: 3.24.0, 3.25.0 Aug 30, 2023
@ryan-conway ryan-conway modified the milestones: 3.25.0, 3.26.0 Oct 25, 2023
thiennguyen0196 added a commit that referenced this issue Oct 31, 2023
@thiennguyen0196
[#491] Update CD workflow to deploy develop branch on staging and mai…
972d6ae 
…n branch on production
@thiennguyen0196 thiennguyen0196 mentioned this issue Oct 31, 2023
Closed
thiennguyen0196 added a commit that referenced this issue Nov 1, 2023
@thiennguyen0196
[#491] Update name of workflows
d843a15
@luongvo luongvo linked a pull request Nov 13, 2023 that will close this issue
[#491] Enhance CICD workflow for releasing production to Firebase App Distribution #554
Closed
@ryan-conway ryan-conway modified the milestones: 3.26.0, 3.27.0, 3.28.0 Dec 1, 2023
@ryan-conway ryan-conway modified the milestones: 3.28.0, 3.29.0 Dec 29, 2023
@ryan-conway ryan-conway removed this from the 3.29.0 milestone May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thiennguyen0196 thiennguyen0196

Labels
priority : normal type : chore
Projects
None yet
Milestone
No milestone
4 participants
@lydiasama @luongvo @thiennguyen0196 @ryan-conway