Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pass "damp" and "scale" to cacl_influence_single #21

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

thongnt99
Copy link

Pass "damp" and "scale" to "cacl_influence_single" method.
I found this when trying to fix the "NAN" problem #6.

@ZaydH
Copy link
Contributor

ZaydH commented Jan 17, 2021

@iamgroot42 added a NaN check in his fork to detect when there is numerical instability. Those are probably worth rolling into a pull request (either this one or a separate one).

I did have to make a change to his version to work properly with newer PyTorch versions. I can share code if you like @zatcsc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants