Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: Fix(SlimSystem): include std assertions and typedthreads #31

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

noahehall
Copy link

@noahehall noahehall commented May 5, 2023

The Problem

  • import threading/channels throws error when --define:nimPreviewSlimSystem
/.nimble/pkgs2/threading-0.1.0-69d57091dff1983d92a3f39ed483bdb20d1b555c/threading/channels.nim(118, 3) 
Error: undeclared identifier: 'assert'
candidates (edit distance, scope distance); see '--spellSuggest': 

nim version

03:40 AM (fix/nimPreviewSlimSystem-import-std-modules %) 
$ nim --v
Nim Compiler Version 1.9.3 [Linux: amd64]
Compiled at 2023-05-02
Copyright (c) 2006-2023 by Andreas Rumpf

git hash: aec5a4c4744a81e19954daf330bafac948098835
active boot switches: -d:release

The Fix

FYI: Doesnt quite fix the issue

git/foss/threading/threading/channels.nim(412, 3) 
Error: ambiguous call; both channels.assert(cond: untyped, msg: string)
 [template declared in /nim-#devel/lib/std/assertions.nim(54, 10)] 
and assertions.assert(cond: untyped, msg: string) 
[template declared in /nim-#devel/lib/std/assertions.nim(54, 10)] match for: ()

What am I doing wrong?
i tried using --multimethods:on but that had 0 effect

@noahehall noahehall force-pushed the fix/nimPreviewSlimSystem-import-std-modules branch from 934fd9a to 0c8568f Compare May 5, 2023 12:32
@noahehall noahehall force-pushed the fix/nimPreviewSlimSystem-import-std-modules branch from 0c8568f to 6bb43c9 Compare May 5, 2023 12:33
@noahehall noahehall changed the title Fix(SlimSystem): include std assertions and typedthreads Draft: Fix(SlimSystem): include std assertions and typedthreads May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant