Fixes #24369 #24370
Fixes #24369 #24370
Conversation
| @@ -2969,5 +2969,4 @@ proc arrayWith*[T](y: T, size: static int): array[size, T] {.raises: [].} = | |||
| when nimvm: | |||
| result[i] = y | |||
| else: | |||
| # TODO: fixme it should be `=dup` | |||
| result[i] = y | |||
| result[i] = `=dup`(y) | |||
There was a problem hiding this comment.
Problem is that the comment is wrong and the explicit =dup should not be necessary.
There was a problem hiding this comment.
So, if I understand correctly, the current implementation of arrayWith is correct as it has been so far (as we actually will copy y, but in the example type we forbid copying values, so semantics seem correct to me). But maybe there would need to be an alternative implementation of this function to implement array initialization using the default proc to generate the default value instead of passing in a default value?
If my assumptions are correct, I guess I would need to make changes in the defaultNodeField proc. Somewhere around here:
Line 674 in 15271db
Hope this fixes #24369, happy for any feedback on the PR.