Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(maint) Update dependency Octokit to v13 #152

Merged
merged 1 commit into from
Jun 28, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/GitHubMilestoneCleaner/GitHubMilestoneCleaner.csproj
Original file line number Diff line number Diff line change
@@ -39,7 +39,7 @@

<ItemGroup>
<PackageReference Include="JetBrains.Annotations" Version="2023.3.0" />
<PackageReference Include="Octokit" Version="12.0.0" />
<PackageReference Include="Octokit" Version="13.0.0" />
<PackageReference Include="Polly" Version="8.4.1" />
<PackageReference Include="Spectre.Console" Version="0.49.1" />
<PackageReference Include="Spectre.Console.Cli" Version="0.49.1" />

Unchanged files with check annotations Beta

global using Xunit;

Check warning on line 1 in src/GitHubMilestoneCleaner.Tests/GlobalUsings.cs

GitHub Actions / build (windows-2022)

C# 10.0 language feature
using System.Collections.Immutable;
using System.Runtime.InteropServices.ComTypes;
using GitHubMilestoneCleaner.Engines;

Check warning on line 3 in src/GitHubMilestoneCleaner.Tests/IssueGroupEngineTests.cs

GitHub Actions / build (windows-2022)

Namespace 'GitHubMilestoneCleaner.Engines' contains no declarations
using Octokit;
using Shouldly;
namespace GitHubMilestoneCleaner.Tests;

Check warning on line 7 in src/GitHubMilestoneCleaner.Tests/IssueGroupEngineTests.cs

GitHub Actions / build (windows-2022)

Namespace body block expected
public class IssueGroupEngineTests
{
public class MockIssueWrapper(string title, int number) : IssueGroupEngine.IIssueWrapper

Check warning on line 11 in src/GitHubMilestoneCleaner.Tests/IssueGroupEngineTests.cs

GitHub Actions / build (windows-2022)

Class cannot have primary constructor
{
public string Title { get; } = title;

Check warning on line 13 in src/GitHubMilestoneCleaner.Tests/IssueGroupEngineTests.cs

GitHub Actions / build (windows-2022)

Cannot resolve symbol 'title'
public long Number { get; } = number;

Check warning on line 14 in src/GitHubMilestoneCleaner.Tests/IssueGroupEngineTests.cs

GitHub Actions / build (windows-2022)

Cannot resolve symbol 'number'
public Issue BackingIssue { get; } = new();
}
// given
var sut = new IssueGroupEngine();
var issues = new[] { lhs, rhs }
.Select(x =>

Check warning on line 29 in src/GitHubMilestoneCleaner.Tests/IssueGroupEngineTests.cs

GitHub Actions / build (windows-2022)

Cannot resolve symbol 'Select'
new MockIssueWrapper(x, 1));

Check warning on line 30 in src/GitHubMilestoneCleaner.Tests/IssueGroupEngineTests.cs

GitHub Actions / build (windows-2022)

Constructor 'MockIssueWrapper' has 0 parameter(s) but is invoked with 2 argument(s)
// when
var f = sut.GroupIssues(issues).ToList();

Check warning on line 33 in src/GitHubMilestoneCleaner.Tests/IssueGroupEngineTests.cs

GitHub Actions / build (windows-2022)

Cannot resolve symbol 'ToList'
// then
f.Count.ShouldBe(1);
// given
var sut = new IssueGroupEngine();
var issues = new[] { lhs, rhs }
.Select(x =>

Check warning on line 48 in src/GitHubMilestoneCleaner.Tests/IssueGroupEngineTests.cs

GitHub Actions / build (windows-2022)

Cannot resolve symbol 'Select'
new MockIssueWrapper(x, 1));
// when