Skip to content

Commit

Permalink
Merge pull request #140 from nils-a/feature/GH-139
Browse files Browse the repository at this point in the history
(#139) issue Number is long, not int
  • Loading branch information
nils-a authored May 10, 2024
2 parents 9a3c43b + 5538228 commit 85d2cb9
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion src/GitHubMilestoneCleaner.Tests/IssueGroupEngineTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ public class IssueGroupEngineTests
public class MockIssueWrapper(string title, int number) : IssueGroupEngine.IIssueWrapper

Check warning on line 11 in src/GitHubMilestoneCleaner.Tests/IssueGroupEngineTests.cs

View workflow job for this annotation

GitHub Actions / build (windows-2022)

Class cannot have primary constructor
{
public string Title { get; } = title;

Check warning on line 13 in src/GitHubMilestoneCleaner.Tests/IssueGroupEngineTests.cs

View workflow job for this annotation

GitHub Actions / build (windows-2022)

Cannot resolve symbol 'title'
public int Number { get; } = number;
public long Number { get; } = number;

Check warning on line 14 in src/GitHubMilestoneCleaner.Tests/IssueGroupEngineTests.cs

View workflow job for this annotation

GitHub Actions / build (windows-2022)

Cannot resolve symbol 'number'
public Issue BackingIssue { get; } = new();
}

Expand Down
2 changes: 1 addition & 1 deletion src/GitHubMilestoneCleaner/Commands/AutoCleanupCommand.cs
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,7 @@ public IssueWrapper(Issue issue)
}

public string Title => BackingIssue.Title;
public int Number => BackingIssue.Number;
public long Number => BackingIssue.Number;
public Issue BackingIssue { get; }
}
}
2 changes: 1 addition & 1 deletion src/GitHubMilestoneCleaner/Engines/IssueGroupEngine.cs
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ public record IssueGroup
public interface IIssueWrapper
{
string Title { get; }
int Number { get; }
long Number { get; }
Issue BackingIssue { get; }
}
}

0 comments on commit 85d2cb9

Please sign in to comment.