Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Passed assertion messege of assert.ok & assert.not.ok #4359

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

webermayank
Copy link

@webermayank webermayank commented Jan 21, 2025

Fixes Passed issue #4307 - Fix static assertions / node assertion messages

Previously the passed message of the assertions were less detailed hence it was hard to know what has actually passed , is it a truthy value or falsy value

Screenshot 2025-01-22 003031

after the fix the message is more detailed with correct value

Screenshot 2025-01-22 002114

  • tested with seperately created file with lots of assertion test

  • await browser.assert.not.ok(false) -- needs to be improved. Instead of the whole block inside (), something simple could be used like: "Testing the value to be not truthy".

  • await browser.assert.ok(true) -- seems okayish but could be improved

  • Perfectly working the prebuild example tests
    @garg3133 Have a look as this, i would love to make any changes if needed

@CLAassistant
Copy link

CLAassistant commented Jan 21, 2025

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants