Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update pivot.cofee(extra null check added to avoid error in case there is no filter data) #1039

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gparida1989
Copy link

extra null check added to avoid error in case there is no filter data

extra null check added to avoid error in case there is no filter data
@gparida1989
Copy link
Author

Hi @nicolaskruchten ,

Is there any issue with validating the PR?

Regards

@nicolaskruchten
Copy link
Owner

Yep, the issue is that I don't have a ton of time to review PRs :) Please be patient!

Can you explain to me under what circumstances it's possible to hit the lines of code you're modifying and for filter to be undefined? This has never happened to me before so I'm not clear on how it's possible.

@gparida1989
Copy link
Author

this occurs when I change my aggregate value to be used the aggregator and my filters are not changed .
so $(this).data("filter"); return null and the immediate line throws error.

@nicolaskruchten
Copy link
Owner

nicolaskruchten commented Nov 8, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants