Add note to README about Redis and Memcached for testing #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm... as the only change here was the README update, this seems to be a problem where tests are inconsistent. Perhaps re-running the travis build will fix this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to run the test suite and had connection failures because I didn't have Memcached running. I had checked for a "CONTRIBUTING" file but the only instructions I found for development were the boilerplate in the README.
This PR just adds a line to the README to note that you need both backends running.
Let me know if you want me to expand this (e.g.
brew install redis memcachedfor macOS) or change any wording.