Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(app/filters): allow filters on variant tags #141

Merged
merged 4 commits into from
Feb 25, 2024
Merged

feat(app/filters): allow filters on variant tags #141

merged 4 commits into from
Feb 25, 2024

Commits on Feb 25, 2024

  1. build(deps): rebuild poetry.lock from pyproject 

    This patch includes the output of running:

```
$ rm poetry.lock
$ poetry install
```

...this was required as I was running into `pyyaml` cython errors.
    @nicholaschiang
    nicholaschiang committed Feb 25, 2024
    Configuration menu
    Copy the full SHA
    0cf482f View commit details
    Browse the repository at this point in the history

  2. chore(scripts/spiders/shopify): remove debug logs

    @nicholaschiang
    nicholaschiang committed Feb 25, 2024
    Configuration menu
    Copy the full SHA
    b5d4bca View commit details
    Browse the repository at this point in the history

  3. feat(app/filters): allow filter on variant tags 

    This patch adds some nested variant filters. In addition to filtering by
a variant's colors, users can now filter on a variant's tags. This
probably requires some polish to automatically support new nested fields
as they come, or, just make it less hacky and more explicit from the
get-go (e.g. specifying which fields can be filtered on upfront).
    @nicholaschiang
    nicholaschiang committed Feb 25, 2024
    Configuration menu
    Copy the full SHA
    c286f41 View commit details
    Browse the repository at this point in the history

  4. fix(app/components/menu): scroll through long list 

    If there is a long list that would overflow beyond the viewport height,
we overflow inside of the menu, instead.
    @nicholaschiang
    nicholaschiang committed Feb 25, 2024
    Configuration menu
    Copy the full SHA
    c599216 View commit details
    Browse the repository at this point in the history