Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: rename Set to Board and add Jupyter notebooks #131

Merged
merged 3 commits into from
Dec 21, 2023

Conversation

nicholaschiang
Copy link
Owner

@nicholaschiang nicholaschiang commented Nov 24, 2023

This PR adds some Jupyter notebooks and renames the Set model to Board due to some Python Prisma issues.


BEFORE THIS IS MERGED:

Copy link

vercel bot commented Nov 24, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
dolce ❌ Failed (Inspect) Dec 21, 2023 11:22pm

@nicholaschiang nicholaschiang force-pushed the nicholas/notebooks branch 2 times, most recently from 0c8ac18 to 85f3fce Compare November 24, 2023 07:14
@nicholaschiang nicholaschiang changed the base branch from nicholas/posts to main November 24, 2023 07:15
@nicholaschiang nicholaschiang changed the title Nicholas/notebooks feat: rename Set to Board and add Jupyter Nov 24, 2023
@nicholaschiang nicholaschiang changed the title feat: rename Set to Board and add Jupyter feat: rename Set to Board and add Jupyter notebooks Nov 24, 2023
This patch adds some Jupyter notebooks for quick experimentation (e.g.
to label the items in my saved Instagram posts).

I added the Python Prisma client to interact with my database in a
relatively type-safe manner in these notebooks.

This patch also updates the GitHub workflows to only generate the JS
Prisma client (as Python dependencies are not installed in CI).
This patch fixes an issue where the `Set` model name would conflict with
the built-in class names in Python and cause the Python Prisma client to
fail. This is a temporary fix, but I also think this will just be easier
to work with in general (as most languages have a `Set` class).

Ref: RobertCraigie/prisma-client-py#842
This patch updates the underlying app implementation to use the newly
renamed `Board` data model instead of the `Set` data model. Note that
this does not update any user-facing naming: Users will still see "sets"
in the UI. Variables are also still named based on sets.

This was the minimal change required to get the app working with the
latest rename Prisma migration.

Fixes: 2f74c5c ("feat(prisma): rename "set" model to "board"")
@nicholaschiang nicholaschiang merged commit 88ddb27 into main Dec 21, 2023
6 of 8 checks passed
@nicholaschiang nicholaschiang deleted the nicholas/notebooks branch December 21, 2023 23:16
@nicholas-release-bot
Copy link

🎉 This PR is included in version 1.63.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant