-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: rename Set
to Board
and add Jupyter notebooks
#131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
nicholaschiang
force-pushed
the
nicholas/posts
branch
from
November 24, 2023 07:13
8a6b4f5
to
da3f927
Compare
nicholaschiang
force-pushed
the
nicholas/notebooks
branch
2 times, most recently
from
November 24, 2023 07:14
0c8ac18
to
85f3fce
Compare
nicholaschiang
changed the title
Nicholas/notebooks
feat: rename Nov 24, 2023
Set
to Board
and add Jupyter
nicholaschiang
changed the title
feat: rename
feat: rename Nov 24, 2023
Set
to Board
and add JupyterSet
to Board
and add Jupyter notebooks
nicholaschiang
force-pushed
the
nicholas/notebooks
branch
from
December 21, 2023 22:45
85f3fce
to
2f74c5c
Compare
nicholaschiang
force-pushed
the
nicholas/notebooks
branch
from
December 21, 2023 23:00
c3c92e1
to
9e8597c
Compare
nicholaschiang
force-pushed
the
nicholas/notebooks
branch
from
December 21, 2023 23:06
dd64dcd
to
be7ffef
Compare
nicholaschiang
force-pushed
the
nicholas/notebooks
branch
from
December 21, 2023 23:09
be7ffef
to
f69b947
Compare
This patch adds some Jupyter notebooks for quick experimentation (e.g. to label the items in my saved Instagram posts). I added the Python Prisma client to interact with my database in a relatively type-safe manner in these notebooks. This patch also updates the GitHub workflows to only generate the JS Prisma client (as Python dependencies are not installed in CI).
This patch fixes an issue where the `Set` model name would conflict with the built-in class names in Python and cause the Python Prisma client to fail. This is a temporary fix, but I also think this will just be easier to work with in general (as most languages have a `Set` class). Ref: RobertCraigie/prisma-client-py#842
This patch updates the underlying app implementation to use the newly renamed `Board` data model instead of the `Set` data model. Note that this does not update any user-facing naming: Users will still see "sets" in the UI. Variables are also still named based on sets. This was the minimal change required to get the app working with the latest rename Prisma migration. Fixes: 2f74c5c ("feat(prisma): rename "set" model to "board"")
nicholaschiang
force-pushed
the
nicholas/notebooks
branch
from
December 21, 2023 23:11
f69b947
to
6b5d0e4
Compare
🎉 This PR is included in version 1.63.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some Jupyter notebooks and renames the
Set
model toBoard
due to some Python Prisma issues.BEFORE THIS IS MERGED:
app
code to be compatible with the newSet
toBoard
changes.