The APU State and Event Timing Status sections use the same GUID #24
Comments
rtzoeller
added a commit
that referenced
this issue
Jan 18, 2019
We were adding the new monitoring channels to the event timing status section unintentionally.
csjall
pushed a commit
that referenced
this issue
Jan 22, 2019
…-fpga configuration (#25) * Remove Main.validBitfile from multi-fpga code This property is no longer as meaningful, and the implementation was incorrect * Initial mutation work for multi-fpga support * Add new APU state channels during mutation, handle multiple APUs * 1.3.3 mutations should use hard coded channel lists This fixes a bug (in addition potential future bugs of the same nature) where the APU State channel list was updated, and as a result mutating from versions prior to 1.3.3 to 1.3.4 would try to double-add the new channels. * Work around #24 We were adding the new monitoring channels to the event timing status section unintentionally. * Decouple feature toggle mutation from version mutation * Address feedback from @csjall Initialize Main.Feature Toggles.Multi FPGA in main page and set after mutating. Added a unit test to validate mutation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Both the APU State and Event Timing Status sections use the same GUID (
F1CEE36E-E483-4565-3A3E-AB06893FB67A, seeGUID.APU State). This makes it difficult to operate on each type of section independently, since you cannot query for them based on the GUID without getting references to both.Event Timing Status should get its own GUID, instead of hijacking APU State's.
The text was updated successfully, but these errors were encountered: