Skip to content

Commit

Permalink
Mutation code for migrating from the 1.3.3 custom device to the multi…
Browse files Browse the repository at this point in the history
…-fpga configuration (#25)

* Remove Main.validBitfile from multi-fpga code

This property is no longer as meaningful, and the implementation was incorrect

* Initial mutation work for multi-fpga support

* Add new APU state channels during mutation, handle multiple APUs

* 1.3.3 mutations should use hard coded channel lists

This fixes a bug (in addition potential future bugs of the same nature) where the APU State channel list was updated, and as a result mutating from versions prior to 1.3.3 to 1.3.4 would try to double-add the new channels.

* Work around #24

We were adding the new monitoring channels to the event timing status section unintentionally.

* Decouple feature toggle mutation from version mutation

* Address feedback from @csjall

Initialize Main.Feature Toggles.Multi FPGA in main page and set after mutating.

Added a unit test to validate mutation.
  • Loading branch information
rtzoeller authored and csjall committed Jan 22, 2019
1 parent 54f6ad0 commit ffff637
Show file tree
Hide file tree
Showing 23 changed files with 13,834 additions and 1 deletion.
2 changes: 1 addition & 1 deletion Source/Custom Device Engine Simulation Toolkit.xml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<eng>National Instruments::Engine Simulation Toolkit</eng>
<loc>National Instruments::Engine Simulation Toolkit</loc>
</AddMenu>
<Version>1.3.3</Version>
<Version>1.3.4</Version>
<Type>Asynchronous</Type>
<MaxOccurrence>-1</MaxOccurrence>
<MainPageGUID>7baffd2f-e585-46fb-ac82-fc4feb050845</MainPageGUID>
Expand Down
1 change: 1 addition & 0 deletions Source/Engine Simulation Toolkit Custom Device.lvproj
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
<Item Name="Unit" Type="Folder">
<Item Name="Bitfile Parsing Test Case.lvclass" Type="LVClass" URL="../Tests/Unit/Bitfile Parsing Test Case/Bitfile Parsing Test Case.lvclass"/>
<Item Name="Scripting API Test Case.lvclass" Type="LVClass" URL="../Tests/Unit/Scripting API Test Case/Scripting API Test Case.lvclass"/>
<Item Name="Mutation Test Case.lvclass" Type="LVClass" URL="../Tests/Unit/Mutation Test Case/Mutation Test Case.lvclass"/>
</Item>
</Item>
<Item Name="Utility" Type="Folder">
Expand Down
Binary file modified Source/Shared/Properties.vi
Binary file not shown.
Original file line number Diff line number Diff line change
Expand Up @@ -181,6 +181,13 @@
<Item Name="Timing Page Wrapper.vi" Type="VI" URL="../Timing Page Wrapper.vi"/>
<Item Name="Timing Page.vi" Type="VI" URL="../Timing Page.vi"/>
</Item>
<Item Name="Mutation" Type="Folder">
<Item Name="Mutate 1.1.1.vi" Type="VI" URL="../Mutate 1.1.1.vi"/>
<Item Name="Mutate 1.2.9.vi" Type="VI" URL="../Mutate 1.2.9.vi"/>
<Item Name="Mutate 1.3.3.vi" Type="VI" URL="../Mutate 1.3.3.vi"/>
<Item Name="Mutate Multi FPGA.vi" Type="VI" URL="../Mutate Multi FPGA.vi"/>
<Item Name="Get 1.3.3 Mutation Chans.vi" Type="VI" URL="../Get 1.3.3 Mutation Chans.vi"/>
</Item>
<Item Name="EnableDisable - Right Click.vi" Type="VI" URL="../EnableDisable - Right Click.vi"/>
<Item Name="Initialization VI.vi" Type="VI" URL="../Initialization VI.vi"/>
<Item Name="Main On Compile Action VI - Multi FPGA.vi" Type="VI" URL="../Main On Compile Action VI - Multi FPGA.vi"/>
Expand Down Expand Up @@ -321,6 +328,7 @@
<Item Name="Get Custom Device Reference.vi" Type="VI" URL="../Get Custom Device Reference.vi"/>
<Item Name="Set Master Bitfile.vi" Type="VI" URL="../Set Master Bitfile.vi"/>
<Item Name="Get Channels For Measurement.vi" Type="VI" URL="../Get Channels For Measurement.vi"/>
<Item Name="Rename String Array Property.vi" Type="VI" URL="../Rename String Array Property.vi"/>
</Item>
<Item Name="Refresh" Type="Folder">
<Item Name="Refresh FPGA Bitfile.vi" Type="VI" URL="../Refresh FPGA Bitfile.vi"/>
Expand Down
Binary file not shown.
Binary file modified Source/System Explorer/Main On Load Action VI.vi
Binary file not shown.
Binary file modified Source/System Explorer/Main Page - Multi FPGA.vi
Binary file not shown.
Binary file added Source/System Explorer/Mutate 1.1.1.vi
Binary file not shown.
Binary file added Source/System Explorer/Mutate 1.2.9.vi
Binary file not shown.
Binary file added Source/System Explorer/Mutate 1.3.3.vi
Binary file not shown.
Binary file added Source/System Explorer/Mutate Multi FPGA.vi
Binary file not shown.
Binary file modified Source/System Explorer/Parse Bitfile for EST IP - Multi FPGA.vi
Binary file not shown.
Binary file not shown.
Loading

0 comments on commit ffff637

Please sign in to comment.