Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(TranslateService): load translations if they have not been loaded before (#1193)(#1266) #1361

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dfmeretzki
Copy link

@dfmeretzki dfmeretzki commented Jan 19, 2022

This PR contains no breaking changes.

When the translateService.use(...) method is called nothing happens if the current language is the same as the one passed as parameter. This causes that after changing the language in one instance of the translate service the rest of instances don't fetch the translations if they don't use isolate = true since the current language is the same as the one passed as parameter. That is why workarounds like this

translateService.currentLang = '';
translateService.use ('en');

worked. Removing the first return statement leaves the service check if it has the translations and gets them if they have not been loaded before. It fixes (#1193)(#1266) between other issues I am not able to find now.

@dfmeretzki
Copy link
Author

also fixes #602 #444 #425

@dfmeretzki dfmeretzki changed the title core(TranslateService): load translations if they have not been loaded before (#1193)(#1266) fix(TranslateService): load translations if they have not been loaded before (#1193)(#1266) Jan 22, 2022
@roberthajdu
Copy link

When this gonna be added? Its a blocking issue.

@liesahead
Copy link

Sad that library seems to be abandoned

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants