Refactor ModalInsertLink and setupInsertLinkMenu

nguyenvanduocit · Dec 13, 2023 · babf4c2 · babf4c2
1 parent ce3e898
commit babf4c2
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 8 deletions.
diff --git a/src/ModalInsertLink.ts b/src/ModalInsertLink.ts
@@ -25,12 +25,9 @@ export class ModalInsertLink extends Modal {
             .setName('URL')
             .setClass('open-gate--form-field')
             .addText((text) =>
-                text
-                    .setPlaceholder('https://example.com')
-
-                    .onChange(async (value) => {
-                        gateOptions.url = value
-                    })
+                text.setPlaceholder('https://example.com').onChange(async (value) => {
+                    gateOptions.url = value
+                })
             )
 
         new Setting(this.contentEl)

diff --git a/src/fns/setupInsertLinkMenu.ts b/src/fns/setupInsertLinkMenu.ts
@@ -10,10 +10,12 @@ export const setupInsertLinkMenu = (plugin: Plugin) => {
 const createMenu = (app: App, menu: Menu, editor: Editor) => {
     menu.addItem((item) => {
         item.setTitle('Insert Gate Link').onClick(async () => {
-            new ModalInsertLink(app, async (gate: GateFrameOption) => {
+            const modal = new ModalInsertLink(app, async (gate: GateFrameOption) => {
                 const gateLink = `[${gate.title}](obsidian://opengate?title=${encodeURIComponent(gate.title)}&url=${encodeURIComponent(gate.url)})`
                 editor.replaceSelection(gateLink)
-            }).open()
+                modal.close()
+            })
+            modal.open()
         })
     })
 }