Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spelling #395

Merged
merged 13 commits into from
Jan 11, 2025
Merged

Spelling #395

merged 13 commits into from
Jan 11, 2025

Conversation

jsoref
Copy link
Contributor

@jsoref jsoref commented Jan 10, 2025

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

This PR corrects misspellings identified by the check-spelling action

The misspellings have been reported at https://github.com/jsoref/falso/actions/runs/12717498149#summary-35454062667

What is the new behavior?

The action reports that the changes in this PR would almost make it happy: https://github.com/jsoref/falso/actions/runs/12717498248#summary-35454062399 (I'd need to add a thing telling to tolerate the deprecated api and I'm in a hurry, so I didn't)

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

jsoref added 13 commits January 10, 2025 15:45
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Copy link

stackblitz bot commented Jan 10, 2025

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@NetanelBasal NetanelBasal merged commit 6c58305 into ngneat:main Jan 11, 2025
2 checks passed
@jsoref jsoref deleted the spelling branch January 12, 2025 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants