add guard to loop to avoid stuck

ngneat · Jan 9, 2025 · 6e9b69a · 6e9b69a
1 parent 8fc3407
commit 6e9b69a
Showing 1 changed file with 11 additions and 1 deletion.
diff --git a/packages/falso/src/lib/phone-number.ts b/packages/falso/src/lib/phone-number.ts
@@ -269,8 +269,11 @@ export function randPhoneNumber<Options extends PhoneNumberOptions = never>(
 
   const generateValidPhoneNumber = (): string => {
     let validNumber: string | null = null;
+    const maxRetries = 100; // Set a limit to prevent infinite loops
+    let attempts = 0;
 
-    while (!validNumber) {
+    while (!validNumber && attempts < maxRetries) {
+      attempts++;
       const phoneNumber = randMask({
         mask: randElement(formats),
       });
@@ -281,6 +284,12 @@ export function randPhoneNumber<Options extends PhoneNumberOptions = never>(
       }
     }
 
+    if (!validNumber) {
+      throw new Error(
+        `Failed to generate a valid phone number after ${maxRetries} attempts.`
+      );
+    }
+
     return validNumber;
   };
 
@@ -290,3 +299,4 @@ export function randPhoneNumber<Options extends PhoneNumberOptions = never>(
 
   return fake(phoneNumber, options);
 }
+