1929: local modules use remote format from template #3256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awgymer
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files☔ View full report in Codecov by Sentry. |
mirpedrol
reviewed
Oct 29, 2024
nf_core/modules/lint/module_tests.py
Outdated
| @@ -22,6 +22,8 @@ def module_tests(_, module: NFCoreComponent): | |||
| and contains a ``main.nf.test`` and a ``main.nf.test.snap`` | |||
|
|
|||
| """ | |||
| if module.nftest_testdir is None or module.nftest_main_nf is None: | |||
| raise ValueError() | |||
There was a problem hiding this comment.
don't we want to allow local modules to not have these files?
There was a problem hiding this comment.
Yes, this was my first-pass to get mypy happy so I could run the tests on GitHub yesterday. I am updating the individual lint tests to be a bit more permissive of missing files for local modules.
mirpedrol
reviewed
Oct 29, 2024
|
There are currently no tests at all implemented for the linting of local modules or subworkflows 😱 |
mirpedrol
approved these changes
Oct 30, 2024
Co-authored-by: Júlia Mir Pedrol <[email protected]>
awgymer
force-pushed
the
1929-local-modules-use-remote-format
branch
from
e7d58cb to
5689ff6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
CHANGELOG.mdis updateddocsis updated