Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update awstest #433

Merged
merged 5 commits into from
Nov 13, 2023
Merged

update awstest #433

merged 5 commits into from
Nov 13, 2023

Conversation

rannick
Copy link
Collaborator

@rannick rannick commented Nov 8, 2023 •
edited
Loading

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/rnafusion branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 8, 2023 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit de3a105

+| ✅ 158 tests passed       |+
!| ❗   2 tests had warnings |!

❗ Test warnings:

  • files_exist - File not found: conf/igenomes.config
  • pipeline_todos - TODO string in WorkflowRnafusion.groovy: Optionally add in-text citation tools to this list.

✅ Tests passed:

Run details

  • nf-core/tools version 2.10
  • Run at 2023-11-13 08:34:40

@rannick rannick self-assigned this Nov 13, 2023
@rannick rannick marked this pull request as ready for review November 13, 2023 08:29
@rannick rannick requested a review from peterpru November 13, 2023 08:33
peterpru
peterpru approved these changes Nov 13, 2023
View reviewed changes
Copy link
Member

@peterpru peterpru left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks okay to me. I am new to AWS tests, so I do not know 100% if there is anything missing, but I think it looks good. 👍

@rannick
Copy link
Collaborator Author

rannick commented Nov 13, 2023

I tested with stubs here https://github.com/nf-core/rnafusion/actions/workflows/awstest.yml

@rannick rannick merged commit 0ad3a0d into dev Nov 13, 2023
8 checks passed
@rannick rannick deleted the update_aws branch November 13, 2023 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterpru peterpru peterpru approved these changes

Assignees

@rannick rannick

Labels
waiting-for-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rannick @peterpru