Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiqc #88

Merged
merged 65 commits into from
Jun 17, 2024
Merged
Show file tree
Hide file tree
Changes from 57 commits
Commits
Show all changes
65 commits
Select commit Hold shift + click to select a range
31bf093
Add stats to multiqc
Jun 7, 2024
5ba53ae
Add parameter sim_by_chr and dinamically publish downsampled file
Jun 7, 2024
01f3814
Add description and change parameter name
Jun 7, 2024
ed7fc91
Change to used input_region
Jun 8, 2024
f30cfaa
Simplify channels creations
Jun 8, 2024
1c8bf4c
correct typo which raised error
atrigila Jun 7, 2024
e5a4eb0
allow external chunks in glimpse1
atrigila Jun 7, 2024
a58c194
emit final prepared vcf
atrigila Jun 7, 2024
3e70142
run test from external params
atrigila Jun 7, 2024
129de0a
accept external chunks in glimpse2
atrigila Jun 7, 2024
fbbc87e
remove posfile not used in glimpse2
atrigila Jun 7, 2024
ec44ae8
make meta.id uniform across all schemas
atrigila Jun 7, 2024
a676f34
use input panel from panelprep
atrigila Jun 8, 2024
247951c
change chunks to those from specific region
atrigila Jun 8, 2024
b4dd4cf
update changelog
atrigila Jun 8, 2024
5705fb3
update snapshot
atrigila Jun 8, 2024
46ca0a1
Update multiqc report
Jun 9, 2024
edc0e08
Merge branch 'dev' into multiqc
LouisLeNezet Jun 11, 2024
af47ed5
Update changelog
LouisLeNezet Jun 11, 2024
3ffdcda
Fix linting
LouisLeNezet Jun 11, 2024
535bc0e
Add patch for bcftools pluginsplit
LouisLeNezet Jun 11, 2024
2c99026
Fix linting
LouisLeNezet Jun 11, 2024
5b02a2c
Update snapshot
LouisLeNezet Jun 11, 2024
7f36c8c
move bcftools_convert to vcf_sites_extract
atrigila Jun 8, 2024
581240f
move channel definition to panelprep
atrigila Jun 8, 2024
f3beb18
move channel haplegend from panel to posfile
atrigila Jun 9, 2024
5dcd43e
remove haplegend check in panel
atrigila Jun 9, 2024
7a2fe37
update docs
atrigila Jun 9, 2024
0566d6d
update docs
atrigila Jun 9, 2024
0a295be
correctly define ch_posfile
atrigila Jun 9, 2024
51a5eb7
add tags to print id and chr when running
atrigila Jun 9, 2024
a29ae28
correct samtools depth tag
atrigila Jun 9, 2024
1d3574a
Update conf/steps/validation.config
atrigila Jun 11, 2024
5ca6ea3
Update conf/steps/simulation.config
atrigila Jun 11, 2024
cbefc66
add haplegend for chr21
atrigila Jun 11, 2024
ea8e489
Add stats to multiqc
Jun 7, 2024
15ea394
Add parameter sim_by_chr and dinamically publish downsampled file
Jun 7, 2024
d63350e
Add description and change parameter name
Jun 7, 2024
ebac4b2
Change to used input_region
Jun 8, 2024
0436807
Simplify channels creations
Jun 8, 2024
eb7a42e
emit final prepared vcf
atrigila Jun 7, 2024
5d8cc46
accept external chunks in glimpse2
atrigila Jun 7, 2024
f8755eb
use input panel from panelprep
atrigila Jun 8, 2024
0a369f1
Update multiqc report
Jun 9, 2024
7c92b3c
Change names for multiqc
Jun 12, 2024
50dd78a
Move to bcf for glimpse2
Jun 12, 2024
bb8e183
Fix indent
Jun 12, 2024
71e655d
Update snap with stats
Jun 12, 2024
06abcb9
Update stitch samples id to correctly assess it from filename
Jun 12, 2024
762b791
Remove versions.yml from output
Jun 12, 2024
1138ee9
Add indent
Jun 12, 2024
acc9294
Add chunks for chr 21
Jun 12, 2024
32df3c7
Fix main script
Jun 12, 2024
428b819
Update nf-test
Jun 12, 2024
77a7a00
Merge branch 'dev' into multiqc
LouisLeNezet Jun 12, 2024
61c5a8b
Update test
Jun 12, 2024
ed5fae9
Update test and align params
Jun 12, 2024
6351deb
Move to dot
LouisLeNezet Jun 13, 2024
ab8b036
Remove dot from panel
LouisLeNezet Jun 13, 2024
8b04ba6
Update multiqc config
LouisLeNezet Jun 13, 2024
636107c
Fix csv
LouisLeNezet Jun 13, 2024
d109b0b
Order tools
LouisLeNezet Jun 13, 2024
8684f31
Add check for all imputation tools
LouisLeNezet Jun 13, 2024
b81c002
Update snapshot
LouisLeNezet Jun 13, 2024
8964fe2
Set yml to 2 indent
LouisLeNezet Jun 13, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ Initial release of nf-core/phaseimpute, created with the [nf-core](https://nf-co
- [#84](https://github.com/nf-core/phaseimpute/pull/84) - Change depth computation to use SAMTOOLS_DEPTH and make separation by chromosome only if regions are specified.
- [#85](https://github.com/nf-core/phaseimpute/pull/85) - Use external params in individual tests for tools.
- [#86](https://github.com/nf-core/phaseimpute/pull/86) - Move `bcftools_convert` to `vcf_sites_extract_bcftools`.
- [#88](https://github.com/nf-core/phaseimpute/pull/88) - Improve multiqc report with more information.

### `Fixed`

Expand Down
10 changes: 10 additions & 0 deletions assets/multiqc_config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,16 @@ report_section_order:
"nf-core-phaseimpute-summary":
order: -1002

top_modules:
- "samtools":
name: "Samtools coverage before and after downsampling"
path_filters:
- "*_.stats"
- "bcftools":
name: "BCFtools stats of phased reference panel"
path_filters:
- "*_bcftools_stats.txt"

export_plots: true

disable_version_detection: true
4 changes: 2 additions & 2 deletions assets/schema_input.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@
"properties": {
"sample": {
"type": "string",
"pattern": "^\\S+$",
"errorMessage": "Sample name must be provided and cannot contain spaces",
"pattern": "^[a-zA-Z0-9]+$",
"errorMessage": "Sample name must be provided and cannot contain spaces nor special characters '_' or '.' .",
LouisLeNezet marked this conversation as resolved.
Show resolved Hide resolved
"meta": ["id"]
},
"file": {
Expand Down
47 changes: 46 additions & 1 deletion conf/modules.config
Original file line number Diff line number Diff line change
Expand Up @@ -18,12 +18,57 @@ process {
saveAs: { filename -> filename.equals('versions.yml') ? null : filename }
]

withName: 'MULTIQC' {
withName: 'NFCORE_PHASEIMPUTE:PHASEIMPUTE:MULTIQC' {
LouisLeNezet marked this conversation as resolved.
Show resolved Hide resolved
ext.args = { params.multiqc_title ? "--title \"$params.multiqc_title\"" : '' }
publishDir = [
path: { "${params.outdir}/multiqc" },
mode: params.publish_dir_mode,
saveAs: { filename -> filename.equals('versions.yml') ? null : filename }
]
}

// Stats
// Simulation
// Coverage process
withName: 'NFCORE_PHASEIMPUTE:PHASEIMPUTE:SAMTOOLS_COVERAGE_TRT' {
ext.prefix = { "${meta.id}_A-truth" }
LouisLeNezet marked this conversation as resolved.
Show resolved Hide resolved
publishDir = [ enabled: false ]
}
withName: 'NFCORE_PHASEIMPUTE:PHASEIMPUTE:SAMTOOLS_COVERAGE_SIM' {
ext.prefix = { "${meta.id}_B-sim" }
publishDir = [ enabled: false ]
}

// VCF
// PANEL
withName: 'NFCORE_PHASEIMPUTE:PHASEIMPUTE:BCFTOOLS_STATS_PANEL' {
ext.prefix = { "${meta.id}" }
publishDir = [
path: { "${params.outdir}/prep_panel/stats/" },
mode: params.publish_dir_mode,
enabled: true,
saveAs: { filename -> filename.equals('versions.yml') ? null : filename }
]
}

// TRUTH
withName: 'NFCORE_PHASEIMPUTE:PHASEIMPUTE:BCFTOOLS_STATS_TRUTH' {
ext.prefix = { "${meta.id}_truth" }
publishDir = [
path: { "${params.outdir}/validation/stats" },
mode: params.publish_dir_mode,
enabled: true,
saveAs: { filename -> filename.equals('versions.yml') ? null : filename }
]
}
// IMPUTE
withName: 'NFCORE_PHASEIMPUTE:PHASEIMPUTE:BCFTOOLS_STATS_TOOLS' {
ext.prefix = { "${meta.id}_${meta.tools}" }
publishDir = [
path: { "${params.outdir}/imputation/stats" },
mode: params.publish_dir_mode,
enabled: true,
saveAs: { filename -> filename.equals('versions.yml') ? null : filename }
]
}
}
4 changes: 2 additions & 2 deletions conf/steps/imputation_glimpse1.config
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ process {
"-Aim",
"-C alleles"
].join(' ')
ext.prefix = { "${meta.id}.call" }
ext.prefix = { "${meta.id}" }
}

withName: 'NFCORE_PHASEIMPUTE:PHASEIMPUTE:VCF_IMPUTE_GLIMPSE1:BAM_GL_BCFTOOLS:BCFTOOLS_ANNOTATE' {
Expand Down Expand Up @@ -74,6 +74,7 @@ process {
publishDir = [
path: { "${params.outdir}/imputation/glimpse1/concat" },
mode: params.publish_dir_mode,
saveAs: { filename -> filename.equals('versions.yml') ? null : filename }
]
}

Expand All @@ -84,6 +85,5 @@ process {

withName: 'NFCORE_PHASEIMPUTE:PHASEIMPUTE:CONCAT_GLIMPSE1:BCFTOOLS_INDEX' {
ext.args = "--tbi"
ext.prefix = { "${meta.id}_glimpse1" }
}
}
6 changes: 3 additions & 3 deletions conf/steps/imputation_glimpse2.config
Original file line number Diff line number Diff line change
Expand Up @@ -20,12 +20,12 @@ process {
withName: 'NFCORE_PHASEIMPUTE:PHASEIMPUTE:VCF_IMPUTE_GLIMPSE2:GLIMPSE2_PHASE' {
ext.prefix = { "${meta.id}_${meta.chunk.replace(':','_')}_glimpse2" }
ext.args = "--keep-monomorphic-ref-sites"
ext.suffix = "vcf.gz"
ext.suffix = "bcf"
publishDir = [ enabled: false ]
}

withName: 'NFCORE_PHASEIMPUTE:PHASEIMPUTE:VCF_IMPUTE_GLIMPSE2:BCFTOOLS_INDEX_1' {
ext.args = "--tbi"
ext.args = "--csi"
LouisLeNezet marked this conversation as resolved.
Show resolved Hide resolved
publishDir = [ enabled: false ]
}

Expand All @@ -45,6 +45,7 @@ process {
publishDir = [
path: { "${params.outdir}/imputation/glimpse2/concat" },
mode: params.publish_dir_mode,
saveAs: { filename -> filename.equals('versions.yml') ? null : filename }
]
}

Expand All @@ -55,7 +56,6 @@ process {

withName: 'NFCORE_PHASEIMPUTE:PHASEIMPUTE:CONCAT_GLIMPSE2:BCFTOOLS_INDEX' {
ext.args = "--tbi"
ext.prefix = { "${meta.id}_glimpse2" }
}

}
1 change: 1 addition & 0 deletions conf/steps/imputation_quilt.config
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@ process {
publishDir = [
path: { "${params.outdir}/imputation/quilt/concat" },
mode: params.publish_dir_mode,
saveAs: { filename -> filename.equals('versions.yml') ? null : filename }
]
}

Expand Down
2 changes: 2 additions & 0 deletions conf/steps/imputation_stitch.config
Original file line number Diff line number Diff line change
Expand Up @@ -56,11 +56,13 @@ process {
publishDir = [
path: { "${params.outdir}/imputation/stitch/concat" },
mode: params.publish_dir_mode,
saveAs: { filename -> filename.equals('versions.yml') ? null : filename }
]
}

withName: 'NFCORE_PHASEIMPUTE:PHASEIMPUTE:VCF_SAMPLES_BCFTOOLS:BCFTOOLS_PLUGINSPLIT' {
ext.args = "-Oz"
ext.suffix = "_stitch"
}

withName: 'NFCORE_PHASEIMPUTE:PHASEIMPUTE:VCF_SAMPLES_BCFTOOLS:BCFTOOLS_INDEX' {
Expand Down
16 changes: 16 additions & 0 deletions conf/steps/panel_prep.config
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ process {
publishDir = [
path: { "${params.outdir}/prep_panel/" },
mode: params.publish_dir_mode,
saveAs: { filename -> filename.equals('versions.yml') ? null : filename },
enabled: false
]
tag = {"${meta.id} ${meta.chr}"}
Expand Down Expand Up @@ -55,6 +56,7 @@ process {
ext.prefix = { "${meta.id}_${meta.chr}_biallelic_snps" }
publishDir = [
path: { "${params.outdir}/prep_panel/normalized" },
saveAs: { filename -> filename.equals('versions.yml') ? null : filename },
enabled: true
]
}
Expand All @@ -63,6 +65,7 @@ process {
ext.args = "--tbi"
publishDir = [
path: { "${params.outdir}/prep_panel/normalized" },
saveAs: { filename -> filename.equals('versions.yml') ? null : filename },
enabled: true
]
}
Expand All @@ -73,6 +76,7 @@ process {
ext.prefix = { "${meta.id}_${meta.chr}_biallelic_removed_samples" }
publishDir = [
path: { "${params.outdir}/prep_panel/normalized" },
saveAs: { filename -> filename.equals('versions.yml') ? null : filename },
enabled: true
]
}
Expand All @@ -81,6 +85,7 @@ process {
ext.args = "--tbi"
publishDir = [
path: { "${params.outdir}/prep_panel/normalized" },
saveAs: { filename -> filename.equals('versions.yml') ? null : filename },
enabled: true
]
}
Expand All @@ -89,6 +94,7 @@ process {
ext.prefix = { "${meta.id}_${meta.chr}" }
publishDir = [
path: { "${params.outdir}/prep_panel/compute_freq" },
saveAs: { filename -> filename.equals('versions.yml') ? null : filename },
enabled: true
]
}
Expand All @@ -106,6 +112,7 @@ process {
publishDir = [
path: { "${params.outdir}/prep_panel/phasing" },
mode: params.publish_dir_mode,
saveAs: { filename -> filename.equals('versions.yml') ? null : filename },
enabled: false
]
tag = {"${meta.id} ${meta.chr}"}
Expand All @@ -131,6 +138,7 @@ process {
publishDir = [
path: { "${params.outdir}/prep_panel/haplegend/" },
mode: params.publish_dir_mode,
saveAs: { filename -> filename.equals('versions.yml') ? null : filename },
enabled: true
]
}
Expand All @@ -148,6 +156,7 @@ process {
publishDir = [
path: { "${params.outdir}/prep_panel/sites/vcf/" },
mode: params.publish_dir_mode,
saveAs: { filename -> filename.equals('versions.yml') ? null : filename },
enabled: true
]
}
Expand All @@ -157,6 +166,7 @@ process {
publishDir = [
path: { "${params.outdir}/prep_panel/sites/vcf/" },
mode: params.publish_dir_mode,
saveAs: { filename -> filename.equals('versions.yml') ? null : filename },
enabled: true
]
}
Expand All @@ -178,6 +188,7 @@ process {
publishDir = [
path: { "${params.outdir}/prep_panel/sites/tsv/" },
mode: params.publish_dir_mode,
saveAs: { filename -> filename.equals('versions.yml') ? null : filename },
enabled: true
]
}
Expand All @@ -192,6 +203,7 @@ process {
publishDir = [
path: { "${params.outdir}/prep_panel/sites/tsv/" },
mode: params.publish_dir_mode,
saveAs: { filename -> filename.equals('versions.yml') ? null : filename },
enabled: true
]
}
Expand All @@ -210,6 +222,7 @@ process {
publishDir = [
path: { "${params.outdir}/prep_panel/chunks/" },
mode: params.publish_dir_mode,
saveAs: { filename -> filename.equals('versions.yml') ? null : filename },
enabled: true
]
tag = {"${meta.id} ${meta.chr}"}
Expand All @@ -220,6 +233,7 @@ process {
publishDir = [
path: { "${params.outdir}/prep_panel/chunks/glimpse1/" },
mode: params.publish_dir_mode,
saveAs: { filename -> filename.equals('versions.yml') ? null : filename },
enabled: true
]
}
Expand All @@ -229,6 +243,7 @@ process {
publishDir = [
path: { "${params.outdir}/prep_panel/chunks/glimpse2/" },
mode: params.publish_dir_mode,
saveAs: { filename -> filename.equals('versions.yml') ? null : filename },
enabled: true
]
}
Expand All @@ -238,6 +253,7 @@ process {
publishDir = [
path: { "${params.outdir}/prep_panel/chunks/glimpse2/" },
mode: params.publish_dir_mode,
saveAs: { filename -> filename.equals('versions.yml') ? null : filename },
enabled: true
]
}
Expand Down
10 changes: 0 additions & 10 deletions conf/steps/simulation.config
Original file line number Diff line number Diff line change
Expand Up @@ -57,14 +57,4 @@ process {
ext.args = ""
tag = {"${meta.id}"}
}

// Coverage process
withName: 'NFCORE_PHASEIMPUTE:PHASEIMPUTE:SAMTOOLS_COVERAGE_TRT' {
ext.prefix = { "${meta.id}_truth" }
publishDir = [ enabled: false ]
}
withName: 'NFCORE_PHASEIMPUTE:PHASEIMPUTE:SAMTOOLS_COVERAGE_SIM' {
ext.prefix = { "${meta.id}" }
publishDir = [ enabled: false ]
}
}
4 changes: 2 additions & 2 deletions conf/steps/validation.config
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ process {
"-Aim",
"-C alleles"
].join(' ')
ext.prefix = { "${meta.id}_truth.call" }
ext.prefix = { "${meta.id}_truth" }
}

withName: 'NFCORE_PHASEIMPUTE:PHASEIMPUTE:GL_TRUTH:BCFTOOLS_ANNOTATE' {
Expand All @@ -43,7 +43,6 @@ process {

// Concatenate the truth set
withName: 'NFCORE_PHASEIMPUTE:PHASEIMPUTE:CONCAT_TRUTH:.*' {
ext.prefix = { "${meta.id}_truth_concat" }
publishDir = [
path: { "${params.outdir}/validation/concat" },
mode: params.publish_dir_mode,
Expand All @@ -53,6 +52,7 @@ process {

withName: 'NFCORE_PHASEIMPUTE:PHASEIMPUTE:CONCAT_TRUTH:BCFTOOLS_CONCAT' {
ext.args = ["--ligate", "--output-type z",].join(' ')
ext.prefix = { "${meta.id}_A-truth" }
}

withName: 'NFCORE_PHASEIMPUTE:PHASEIMPUTE:CONCAT_TRUTH:BCFTOOLS_INDEX' {
Expand Down
8 changes: 4 additions & 4 deletions conf/test.config
Original file line number Diff line number Diff line change
Expand Up @@ -25,18 +25,18 @@ params {

// Genome references
fasta = params.pipelines_testdata_base_path + "reference_genome/21_22/hs38DH.chr21_22.fa"
panel = "${projectDir}/tests/csv/panel_2.csv"
panel = "${projectDir}/tests/csv/panel.csv"
phased = true

// Pipeline steps
steps = "impute"
steps = "impute"

// External params
chunks = "${projectDir}/tests/csv/chunks.csv"
chunks = "${projectDir}/tests/csv/chunks.csv"
posfile = "${projectDir}/tests/csv/posfile.csv"

// Impute tools
tools = "glimpse1"
tools = "glimpse1"
}


Loading