Skip to content

Commit

Permalink
Update changelog and remove bcftools query from config
Browse files Browse the repository at this point in the history
  • Loading branch information
LouisLeNezet committed Nov 13, 2024
1 parent 028f097 commit 3c75649
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 12 deletions.
2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ Special thanks to [Matthias Hörtenhuber](https://github.com/mashehu) and [Mazza
- [#117](https://github.com/nf-core/phaseimpute/pull/117) - Fix directories in CSV.
- [#151](https://github.com/nf-core/phaseimpute/pull/151) - Fix `Type not supported: class org.codehaus.groovy.runtime.GStringImpl` error due to `String` test in `getFileExtension()`.
- [#153](https://github.com/nf-core/phaseimpute/pull/153) - Fix getFileExtension function. Fix image in `usage.md`. Fix small warnings and errors with updated language server. `def` has been added when necessary, `:` use instead of `,` in assertions, `_` added to variables not used in closures, `for` loop replaced by `.each{}`, remove unused code / input.
- [#158](https://github.com/nf-core/phaseimpute/pull/158) - Fix contigs usage when regions is only a subset of the given contigs (e.g. if panel file has the 22 chr and the region file only 2 then only the 2 common will be processed). Fix `VCF_SPLIT_BCFTOOLS` by checking first if there is at least one sample and only if more than one then proceed with splitting.
- [#158](https://github.com/nf-core/phaseimpute/pull/158) - Fix contigs usage when regions is only a subset of the given contigs (e.g. if panel file has the 22 chr and the region file only 2 then only the 2 common will be processed). Fix `multiQC` samples names for better comprehension. Fix `-resume` errors when `ch_fasta` is use by adding `cache = 'lenient'` in necessary processes. Fix `BCFTOOLS_PLUGINSPLIT` in edge case with only one sample. Fix `--window-size` of `GLIMPSE_CHUNK` from `4` to `4000000`.

### `Dependencies`

Expand Down
7 changes: 0 additions & 7 deletions conf/modules.config
Original file line number Diff line number Diff line change
Expand Up @@ -87,13 +87,6 @@ process {
}

// Split by samples for each tool
withName: 'NFCORE_PHASEIMPUTE:PHASEIMPUTE:VCF_SPLIT_BCFTOOLS:BCFTOOLS_QUERY' {
tag = { "${meta.id} Batch ${meta.batch} ${meta.tools}" }
ext.args = "--list-samples"
ext.prefix = { "${meta.id}.batch${meta.batch}.${meta.tools}" }
publishDir = [enabled: false]
}

withName: 'NFCORE_PHASEIMPUTE:PHASEIMPUTE:VCF_SPLIT_BCFTOOLS:BCFTOOLS_PLUGINSPLIT' {
tag = { "${meta.id} Batch ${meta.batch} ${meta.tools}" }
ext.args = ["--output-type z", "--write-index=tbi"].join(' ')
Expand Down
4 changes: 0 additions & 4 deletions subworkflows/local/vcf_split_bcftools/tests/nextflow.config
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,6 @@ process {
ext.args = ["--write-index=tbi", "--output-type z"].join(' ')
}

withName: BCFTOOLS_QUERY {
ext.args = "--list-samples"
}

withName: BCFTOOLS_PLUGINSPLIT {
ext.args = ["--write-index=tbi", "--output-type z"].join(' ')
}
Expand Down

0 comments on commit 3c75649

Please sign in to comment.