Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pipeline level ci #115

Merged
merged 10 commits into from
May 6, 2024
Merged

Add pipeline level ci #115

merged 10 commits into from
May 6, 2024

Conversation

JoseEspinosa
Copy link
Member

Another addition towards #95 completion.

@mathysgrapotte
Copy link
Contributor

It seems that stimulus is trying to run deep learning workflow on the GitHub actions, since this workload is too much, the ci actions get cancelled.

@alessiovignoli alessiovignoli self-requested a review May 6, 2024 08:47
@@ -38,7 +38,7 @@ def main(data_csv, config_json, out_path):

# Transform the data according to what defined in the experiment class and the specifics of the user in the Json
# in case of no transformation specification so when the config has "augmentation" : None just save a copy of the original csv file
if config["transform"]:
if "transform" in config:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no we want to know if the key associated to tranform is not None, not that the keyword "transform" is in the config. for the moment let's leave it like it is.

Suggested change
if "transform" in config:
if config["transform"]:

@JoseEspinosa JoseEspinosa merged commit a85b0ff into nf-core:main May 6, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants