-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update responsive view #83
Conversation
Signed-off-by: Balint Erdosi <[email protected]>
Signed-off-by: Balint Erdosi <[email protected]>
I am not sure how many people want to add cities on a smartphone. Anyway, they can switch to the desktop view in most mobile browsers so it can be used with an additional tap, therefore I think it is not completely necessary to have it on the mobile view (where space is quite limited anyway). |
it can be nice to have a better UI on mobile, some likes to have it, maybe we can be responsive :) |
I can imagine the use case for adding cities on the mobile interface (e.g. just having arrived to a new city for a few days), as such I would rather risk making it look odd in some edge cases. I wouldn't be hard to make it look nice by modifying the template - however, as long as I'm toying with #80 (Vue migration), I am somewhat motivated to avoid modifying it… :) |
Yes, this sounds like a viable use case, we should leave it in place for now. Another idea for this use case would be to use the geolocation feature of most browsers to automatically find the location based on GPS coordinates. |
Signed-off-by: Balint Erdosi <[email protected]>
I improved a bit on the experience at tablet sizes: the city list jumps earlier to the bottom, and there are some further breakpoints for wider screens, so that more than two cities fit on the horizontal list at a time. Tablet sizes could accommodate a two-row layout, but it would be quite a hassle to rewrite it. Adding geolocation is more complex: OpenWeatherMap takes coordinates into a different parameter than it takes the city name to (?q=cityName vs ?lat=0.00&lon=0.00), either WeatherController.php is to be extended, or the location name would need to be looked up. |
I added some additional weather information now provided by the OpenWeatherMap API, but currently the UI isn't that pretty: Do you have a good idea how we could structure the city pane especially? I think it should be on the top rather than the left side and using the space more efficiently, while the forecast data should be below just sticking to the left at all times. |
I fixed up the desktop view, @berdosi could you take a look if it works with your PR as well: |
Thanks, I'm a fan of the new layout. :) Also, apologies for the late reply. I'd say this PR doesn't break it, and it is some improvement over how the menu is now. I see quite some improvement areas for this PR, though:
|
i dont get it why weather would not follow the usual design standards and in mobile view hide the left panel and display a burger icon instead to temprarily unhide it... is there a special reason for that? |
Too bad, not much talk here... is that app dead? |
mostly not many developers on this one, the API is stable, only design has to be fixed. This app is maintained by 1 person only |
Moving discussion here from #34 (Smartphone view).
Current status:
flex-wrap: wrap;
)LI
as the cities, I not sure we can wrap it into the next row.