Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for de-provisioning users #960

Merged
merged 2 commits into from
Oct 14, 2024
Merged

Conversation

edward-ly
Copy link
Contributor

Resolves #902.

@edward-ly edward-ly force-pushed the feat/de-provision-user branch from 45936f2 to e43c364 Compare October 10, 2024 16:39
@edward-ly edward-ly force-pushed the feat/de-provision-user branch from e43c364 to 7013ec3 Compare October 10, 2024 16:42
@edward-ly edward-ly marked this pull request as ready for review October 10, 2024 16:44
@edward-ly edward-ly requested a review from julien-nc October 10, 2024 16:58
Copy link
Member

@julien-nc julien-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NoCSRFRequired is missing.
We could also make this an OCS controller. If you want to do it in this PR you can, otherwise we'll do it later.

Also, if a 404 is returned, I think it's better if the payload is empty or something like ['error' => 'User not found'].

Copy link
Member

@julien-nc julien-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@julien-nc julien-nc merged commit dfbdb52 into main Oct 14, 2024
44 checks passed
@julien-nc julien-nc deleted the feat/de-provision-user branch October 14, 2024 08:26
@julien-nc julien-nc mentioned this pull request Oct 15, 2024
Copy link

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hard provisioning: de-provisioning should be supported
2 participants