fix: Handle redirect URL containing a ':' #1008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artonge
added
bug
|
Can it happen with another character than ":"? |
Probably yes. But we don't have such reports for now. Thinking about it, I don't think that my solution works, as in case of http://... The initial : will be replaced. |
artonge
force-pushed
the
artonge/fix/path_containing_colon
branch
from
7cc1a2e to
270a2ba
Compare
|
Updated to be more generic. This will remove the protocol and the domain name. |
Fix #1007 Signed-off-by: Louis Chemineau <[email protected]>
artonge
force-pushed
the
artonge/fix/path_containing_colon
branch
from
270a2ba to
6296354
Compare
|
Can you check it does not break the login flow with the desktop client? That was an issue which was fixed by #971 |
julien-nc
approved these changes
Dec 11, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace
parse_urlas it does not support path containing a:.