Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(composer): require psr/log:^1 #625

Merged
merged 1 commit into from
Aug 12, 2024
Merged

Conversation

st3iny
Copy link
Member

@st3iny st3iny commented Aug 12, 2024

It pulls in psr/log:^3 without any constraints which breaks (testing) other apps as the broader ecosystem is still on ^1.

PHP Fatal error: Declaration of Psr\Log\Test\TestLogger::log($level, $message, array $context = []) must be compatible with Psr\Log\AbstractLogger::log($level, Stringable|string $message, array $context = []): void in /home/richard/src/nextcloud/master/dev_apps/mail/vendor/psr/log/Psr/Log/Test/TestLogger.php on line 69 Script phpunit -c tests/phpunit.unit.xml --fail-on-warning handling the test:unit event returned with error code 255

Signed-off-by: Richard Steinmetz <[email protected]>
@st3iny st3iny added dependencies Pull requests that update a dependency file 3. to review Waiting for reviews labels Aug 12, 2024
@st3iny st3iny requested a review from ChristophWurst August 12, 2024 07:45
@st3iny st3iny self-assigned this Aug 12, 2024
@st3iny st3iny merged commit d7e7875 into main Aug 12, 2024
27 checks passed
@st3iny st3iny deleted the chore/composer/require-psr-log-1 branch August 12, 2024 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews dependencies Pull requests that update a dependency file
Projects
Status: ☑️ Done
Development

Successfully merging this pull request may close these issues.

2 participants