Use signal-cli-dbus-rest-api over abandoned signal-web-gateway. #481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See https://gitlab.com/morph027/signal-cli-dbus-rest-api. Signed-off-by: Claus-Justus Heine <[email protected]>
rotdrop
force-pushed
the
bugfix/obsolete-signal-web-gateway
branch
from
af6fd48 to
59f195c
Compare
|
The test-suite needs to be updated: |
5 tasks
vitormattos
reviewed
Feb 14, 2022
| ); | ||
| $body = $response->getBody(); | ||
| $json = json_decode($body, true); | ||
| // determine type of gateway |
There was a problem hiding this comment.
Is this comment necessary?
| // determine type of gateway | ||
| $response = $client->get($this->config->getUrl() . '/v1/about'); | ||
| if ($response->getStatusCode() === 200) { | ||
| // New style gateway https://gitlab.com/morph027/signal-cli-dbus-rest-api |
There was a problem hiding this comment.
Is this comment necessary?
| throw new SmsTransmissionException("error reported by Signal gateway, status=$status, body=$body}"); | ||
| } | ||
| } else { | ||
| // Try old deprecated gateway https://gitlab.com/morph027/signal-web-gateway |
There was a problem hiding this comment.
Is this comment necessary?
| @@ -91,7 +91,7 @@ public function startSetup(IUser $user, string $gatewayName, string $identifier) | |||
| try { | |||
| $gateway->send($user, $identifier, "$verificationNumber is your Nextcloud verification code."); | |||
| } catch (SmsTransmissionException $ex) { | |||
| throw new VerificationTransmissionException('could not send verification code'); | |||
| throw new VerificationTransmissionException('could not send verification code', $ex->getCode(), $ex); | |||
There was a problem hiding this comment.
Have a place of code using the 2th and 3th argument?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://gitlab.com/morph027/signal-cli-dbus-rest-api.
This would fix #478.
I have read #454