fix(files): create suggestions bar #6856
Draft
+100
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6856 +/- ##
==========================================
- Coverage 46.55% 46.53% -0.03%
==========================================
Files 748 727 -21
Lines 34316 34332 +16
Branches 1242 1221 -21
==========================================
Hits 15976 15976
- Misses 17718 17755 +37
+ Partials 622 601 -21 ☔ View full report in Codecov by Sentry. |
Signed-off-by: julia.kirschenheuter <[email protected]>
JuliaKirschenheuter
force-pushed
the
enh/6817-Suggestions-on-smart-picking
branch
from
a1dc138 to
ebc2d27
Compare
juliusknorr
reviewed
Jan 20, 2025
| @@ -612,6 +616,7 @@ export default { | |||
| this.emit('update:content', { | |||
| markdown: proseMirrorMarkdown, | |||
| }) | |||
| this.isEmptyContent = editor.state.doc.nodeSize <= 4 | |||
There was a problem hiding this comment.
What is the background for that fixed number of 4? I'd assume we can also check the text content length directly? Or the resulting markdown length?
juliusknorr
reviewed
Jan 20, 2025
| @@ -58,6 +58,7 @@ | |||
| </template> | |||
| <ContentContainer v-show="contentLoaded" | |||
| ref="contentWrapper" /> | |||
| <SuggestionsBar v-if="isEmptyContent && contentLoaded" /> | |||
There was a problem hiding this comment.
Should only be shown if a markdown file is edited, not for plain text files (e.g. .txt)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
🖼️ Screenshots