-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(menu): Put list items in submenu, add indentation options #6353
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice! Basically good to go, only 2 remarks:
- A separator line between the list options and indentation options would be useful (as per the suggestion)
Sidenote: This change makes it more obvious that once you decide for ordered/unordered list or checklist, you can not change between them. Any specific reason for that? (But that's a different issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, actually missed something: It is "indentation", not "indention". :)
(EDIT: Actually both seem to exist, but "indentation" is the more commonly used one. If we want to be short, then we can use "Increase indent" / "Decrease indent".)
f4a4b7e
to
0576d45
Compare
True, but that's another issue tracked in its own issue already. No idea so far, why this is the case. |
Thanks for the review @jancborchardt. Both added now, see the updated screenshot (I didn't update the screencast) π |
0576d45
to
d6317c1
Compare
d2ff6cf
to
48d0efb
Compare
Fixes: #2438 Contributes to: #2836 Signed-off-by: Jonas <[email protected]>
Makes sure they're a continuous row from 1 to 16 Signed-off-by: Jonas <[email protected]>
48d0efb
to
4a3b2bb
Compare
/backport to stable30 |
Fixes: #2438
Contributes to: #2836
πΌοΈ Screenshots
π Checklist
npm run lint
/npm run stylelint
/composer run cs:check
)