fix(ImageView): Fix detection of editable editor #5020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes images always being displayed as editable, even in readonly editor. Also set `contenteditable` to false in readonly mode. This fixes image captions being editable in readonly editor without session. Signed-off-by: Jonas <[email protected]>
|
/backport to stable27 |
juliusknorr
approved these changes
Nov 22, 2023
|
/backport b99c810 to stable27 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes images always being displayed as editable, even in readonly editor.
Also set
contenteditableto false in readonly mode. This fixes image captions being editable in readonly editor without session.🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)