fix(currentLineMenu): undefined currentParagraph handling

Also improve some type annotations.

Signed-off-by: Max <[email protected]>

src/plugins/currentLineMenu.js

@@ -3,7 +3,8 @@
  * SPDX-License-Identifier: AGPL-3.0-or-later
  */
 
-import { Plugin, PluginKey, EditorState } from '@tiptap/pm/state'
+import { EditorState, Plugin, PluginKey } from '@tiptap/pm/state'
+import { Editor } from '@tiptap/core'
 import { Decoration, DecorationSet } from '@tiptap/pm/view'
 import Vue from 'vue'
 import SmartPickerMenu from '../components/Editor/SmartPickerMenu.vue'
@@ -15,7 +16,7 @@ export const currentLineMenuKey = new PluginKey('currentLineMenu')
  * ProseMirror plugin providing a single decoration for the current line.
  *
  * @param {object} options - options for the plugin
- * @param {object} options.editor - the tiptap editor
+ * @param {Editor} options.editor - the tiptap editor
  *
  * @return {Plugin<DecorationSet>}
  */
@@ -39,9 +40,6 @@ export default function currentLineMenu({ editor }) {
 					return { decorations: DecorationSet.empty }
 				}
 				const currentParagraph = getCurrentParagraph(newState)
-				if (!currentParagraph) {
-					return { decorations: DecorationSet.empty }
-				}
 				const decorations = mapDecorations(value, tr, currentParagraph)
 					|| currentParagraphDecorations(newState.doc, currentParagraph, editor)
 				return { currentParagraph, decorations }
@@ -64,12 +62,12 @@ export default function currentLineMenu({ editor }) {
  *
  * @param {object} value - previous plugin state
  * @param {object} tr - current transaction
- * @param {object} currentParagraph - attributes of the current paragraph
+ * @param {object|undefined} currentParagraph - attributes of the current paragraph
  *
  * @return {false|DecorationSet}
  */
 function mapDecorations(value, tr, currentParagraph) {
-	if (value.currentParagraph?.pos !== currentParagraph.pos) {
+	if (!currentParagraph || currentParagraph.pos !== value.currentParagraph?.pos) {
 		return false
 	}
 	let removedDecorations = false
@@ -87,7 +85,7 @@ function mapDecorations(value, tr, currentParagraph) {
  * Get the paragraph node the cursor is on.
  *
  * @param {EditorState} state - the prosemirror state
- * @return {Node|undefined} - the current paragraph if the cursor is in one
+ * @return {object|undefined} - the current paragraph if the cursor is in one
  */
 function getCurrentParagraph({ selection }) {
 	const { parent, depth } = selection.$anchor
@@ -111,21 +109,24 @@ function getCurrentParagraph({ selection }) {
  * Create a menu decorations for the given paragraph
  *
  * @param {Document} doc - prosemirror doc
- * @param {Node} currentParagraph - paragraph to decorate
- * @param {object} editor - tiptap editor
+ * @param {object|undefined} currentParagraph - paragraph to decorate
+ * @param {Editor} editor - tiptap editor
  *
  * @return {DecorationSet}
  */
 function currentParagraphDecorations(doc, currentParagraph, editor) {
+	if (!currentParagraph) {
+		return { decorations: DecorationSet.empty }
+	}
 	const decorations = [decorationForCurrentParagraph(currentParagraph, editor)]
 	return DecorationSet.create(doc, decorations)
 }
 
 /**
  * Create a decoration for the currentParagraph
  *
- * @param {object} currentParagraph to decorate
- * @param {object} editor - tiptap editor
+ * @param {Node} currentParagraph to decorate
+ * @param {Editor} editor - tiptap editor
  *
  * @return {Decoration}
  */
@@ -140,7 +141,7 @@ function decorationForCurrentParagraph(currentParagraph, editor) {
 /**
  * Create a menu element for the given currentParagraph
  *
- * @param {object} editor - tiptap editor
+ * @param {Editor} editor - tiptap editor
  *
  * @return {Element}
  */