fix(settings): Clarify peculiarities of enabling encryption #50424
+178
−77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
added
design
|
/backport to stable31 |
artonge
approved these changes
Jan 27, 2025
| type="switch" | ||
| @update:checked="displayWarning"> | ||
| {{ t('settings', 'Enable server-side encryption') }} | ||
| </NcCheckboxRadioSwitch> | ||
| <p v-if="encryptionEnabled" id="server-side-encryption-disable-hint" class="disable-hint"> | ||
| {{ t('settings', 'Disabling server side encryption is only possible using OCC, please refer to the documentation.') }} |
There was a problem hiding this comment.
Can we have a link to the documentation?
- Clarify that enabling server side encryption will not encrypt existing files but only new or changed files. - Clarify that server side encryption can only be disabled using OCC - Ensure there is accessible information of encryption state (`disabled` input will not be announced so make it `aria-disabled` instead) - Make warning more prominent by moving it into a dialog Signed-off-by: Ferdinand Thiessen <[email protected]>
susnux
force-pushed
the
fix/encryption-text
branch
from
c60013b to
94e1323
Compare
|
/compile |
Signed-off-by: nextcloud-command <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
disabledinput will not be announced so make itaria-disabledinstead)Screenshots
Checklist